Skip to content

[skip ci] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification#3206

Merged
havetisyan merged 1 commit intoAthenZ:masterfrom
mlajkim:doc/typo-for-id-jag-specification-in-doc
Feb 26, 2026
Merged

[skip ci] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification#3206
havetisyan merged 1 commit intoAthenZ:masterfrom
mlajkim:doc/typo-for-id-jag-specification-in-doc

Conversation

@mlajkim
Copy link
Copy Markdown
Contributor

@mlajkim mlajkim commented Feb 25, 2026

Description

I found a typo where it's written as id-token instead of id_token

Related issue: #3100

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Signed-off-by: Jeongwoo Kim - jekim <jekim@lycorp.co.jp>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @mlajkim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important documentation error by rectifying a typo in the ZTS token exchange requirements. The change ensures that all references to the id_token parameter type align with the correct specification, improving the accuracy and clarity of the documentation for developers implementing token exchange flows.

Highlights

  • Documentation Correction: Corrected a consistent typo in docs/zts_token_exchange_requirements.md where id-token was incorrectly used instead of id_token as per RFC 8693 token exchange specification.
Changelog
  • docs/zts_token_exchange_requirements.md
    • Corrected id-token to id_token in multiple instances for subject_token_type and actor_token_type parameters.
Activity
  • The pull request author confirmed that no breaking changes were introduced.
  • The pull request author confirmed adherence to contribution guidelines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the documentation file docs/zts_token_exchange_requirements.md, changing id-token to id_token. This change aligns the documentation with the token type URI specified in RFC 8693 for token exchange. The change is accurate and improves the documentation's correctness. No other issues were found in this pull request.

@havetisyan havetisyan merged commit ecdb664 into AthenZ:master Feb 26, 2026
3 checks passed
@mlajkim mlajkim deleted the doc/typo-for-id-jag-specification-in-doc branch March 3, 2026 00:41
@mlajkim mlajkim changed the title Doc: typo fixed id-token => id_token for rfc 8693 token exchange specification Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification Mar 6, 2026
@mlajkim mlajkim changed the title Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification [ci skip[ Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification Mar 9, 2026
@mlajkim mlajkim changed the title [ci skip[ Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification [ci skip] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification Mar 9, 2026
@mlajkim mlajkim changed the title [ci skip] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification [ci \\] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification Mar 9, 2026
@mlajkim mlajkim changed the title [ci \\] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification [skip ci] Docfix: typo fixed id-token => id_token for rfc 8693 token exchange specification Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants