Removing ETag for getTransportPolicySnapshot api

[psasidhar]

Description

Removing ETag support for getTransportPolicySnapshot() api since the snapshot doesn't change after it is created.

The earlier api didn't make it into the release, so it is safe to make this change now.

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the getTransportPolicySnapshot() API by eliminating ETag support. This change is based on the understanding that the snapshot data retrieved by this API does not change after its initial creation, rendering ETag-based conditional requests unnecessary. The modification simplifies the API definition and removes unused functionality without introducing breaking changes, as the previous API version was not yet released.

Highlights

• ETag Removal: Removed ETag support (If-None-Match and ETag headers) from the getTransportPolicySnapshot() API definition.
• API Response Simplification: The NOT_MODIFIED expected response for the getTransportPolicySnapshot() API was removed, as it is no longer relevant without ETag support.

Changelog

• core/msd/src/main/rdl/Snapshot.rdli
  • Removed matchingTag and tag parameters, which were used for ETag functionality.
  • Removed NOT_MODIFIED from the list of expected responses for the getTransportPolicySnapshot resource.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes ETag support from the getTransportPolicySnapshot API, based on the premise that snapshots are immutable. My review points out that the API definitions seem to allow for snapshot modification (specifically the active status), which would make ETag caching beneficial for performance. I've added a comment requesting clarification on this discrepancy between the stated goal and the API's capabilities.