Skip to content

add new external member validator attribute for domains#3256

Merged
psasidhar merged 1 commit intomasterfrom
ext-validator
Mar 24, 2026
Merged

add new external member validator attribute for domains#3256
psasidhar merged 1 commit intomasterfrom
ext-validator

Conversation

@havetisyan
Copy link
Copy Markdown
Collaborator

@havetisyan havetisyan commented Mar 24, 2026

Description

initial support to add attribute for domain external validator #3255

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability to define an external member validator for domains. This allows for custom, pluggable logic to validate members against external systems, enhancing security and compliance. The changes span across data models, schema definitions, CLI tooling, database schema, and server-side processing in both Go and Java, ensuring end-to-end support for this new attribute.

Highlights

  • New External Member Validator Interface: Introduced a new Java interface ExternalMemberValidator to allow custom validation logic for external members within a domain.
  • Domain Model Updates: The externalMemberValidator field was added to various domain-related data models (DomainMeta, Domain, TopLevelDomain, SubDomain, UserDomain, DomainData) across both Go and Java clients and server components.
  • Schema and Database Integration: Updated schema definitions (RDL, Go, Java) and the ZMS database schema to support the new externalMemberValidator field, including a new SQL migration script. JDBC operations were modified to persist and retrieve this attribute.
  • ZMS CLI Enhancements: Added a new set-external-member-validator command to the ZMS command-line interface, allowing administrators to configure the validator for domains.
  • ZMS Server Logic Updates: Modified ZMS server-side logic to handle the new externalMemberValidator attribute, including system meta updates, audit logging, and retrieval of signed domain metadata.
  • Comprehensive Testing: Extensive unit tests were added or updated to ensure the correct functionality, validation, persistence, and equality checks for the new externalMemberValidator field across different components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new ExternalMemberValidator concept across the system. It adds an externalMemberValidator field to various domain-related data structures in both Go and Java clients/servers, including schema definitions, RDL, and database updates. A new Java interface ExternalMemberValidator is defined, and corresponding validation logic, persistence, and CLI commands (set-external-member-validator) are implemented. Comprehensive unit tests have been added to cover the functionality, including system meta updates and authorization. Additionally, .cursor/ has been added to the .gitignore file. I have no feedback to provide.

@psasidhar psasidhar merged commit c5a6228 into master Mar 24, 2026
8 checks passed
@psasidhar psasidhar deleted the ext-validator branch March 24, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants