add new external member validator attribute for domains#3256
add new external member validator attribute for domains#3256
Conversation
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new capability to define an external member validator for domains. This allows for custom, pluggable logic to validate members against external systems, enhancing security and compliance. The changes span across data models, schema definitions, CLI tooling, database schema, and server-side processing in both Go and Java, ensuring end-to-end support for this new attribute. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new ExternalMemberValidator concept across the system. It adds an externalMemberValidator field to various domain-related data structures in both Go and Java clients/servers, including schema definitions, RDL, and database updates. A new Java interface ExternalMemberValidator is defined, and corresponding validation logic, persistence, and CLI commands (set-external-member-validator) are implemented. Comprehensive unit tests have been added to cover the functionality, including system meta updates and authorization. Additionally, .cursor/ has been added to the .gitignore file. I have no feedback to provide.
Description
initial support to add attribute for domain external validator #3255
Contribution Checklist:
Attach Screenshots (Optional)