UI: show the role when trying to create a policy from the role page. …

[chandrasekhar1996]

…Role input is disabled

Description

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a user interface improvement for the policy creation workflow. It ensures that when a policy is initiated from a specific role's context, the role's name is visibly presented in a non-editable field within the policy creation form. This change enhances user experience by providing immediate context and preventing unintended modifications to the role during policy definition.

Highlights

• UI Enhancement for Policy Creation: When creating a policy from a role's page, the associated role name is now automatically displayed in a disabled input field, providing clear context to the user.
• Role Prop Propagation: The role property is now passed from AddPolicyToRole to the AddRuleForRoleForm component to facilitate displaying the role information.
• Role Display Logic: The AddRuleForRoleForm component was updated to conditionally render a disabled input field for the role, using NameUtils to format the role's display name.
• Snapshot Test Updates: Existing snapshot tests for AddPolicyToRole were updated to reflect the new UI elements, specifically the disabled role input field.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a read-only 'Role' input field to the AddRuleForRoleForm component, which is used within the AddPolicyToRole functionality. This new field displays the role's display name, derived from the role and domain props. A review comment points out a potential issue where the domain prop might be undefined, which could lead to an incorrect display value for the role.