Allow MySQL test image to be configured via env var#3280
Merged
havetisyan merged 2 commits intoAthenZ:masterfrom Apr 6, 2026
Merged
Allow MySQL test image to be configured via env var#3280havetisyan merged 2 commits intoAthenZ:masterfrom
havetisyan merged 2 commits intoAthenZ:masterfrom
Conversation
Signed-off-by: Benjamin Huff <benjaminehuff@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to configure the MySQL Docker image used in ZMS tests via the ZMS_TEST_MYSQL_IMAGE environment variable, falling back to a default version if the variable is not set. A review comment suggests using the newly defined constant MYSQL_IMAGE_ENV_VAR within the getMySQLImage method to ensure consistency and maintainability.
servers/zms/src/test/java/com/yahoo/athenz/zms/ZMSTestUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Benjamin Huff <benjaminehuff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Certain CI/CD environments cannot pull from Docker Hub. This PR allows the option to specify a different endpoint and image for MySQL. Solution for issue opened here.
Contribution Checklist:
Attach Screenshots (Optional)