S3ClientFactoryTest unit test fails to receive default us-west-2#3283
Merged
abvaidya merged 2 commits intoAthenZ:masterfrom Apr 8, 2026
Merged
S3ClientFactoryTest unit test fails to receive default us-west-2#3283abvaidya merged 2 commits intoAthenZ:masterfrom
abvaidya merged 2 commits intoAthenZ:masterfrom
Conversation
… unit test expecting default region us-west-2 Signed-off-by: Benjamin Huff <benjaminehuff@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the S3ClientFactoryTest to disable EC2 metadata during tests to prevent unnecessary IMDS calls. The review suggests updating the inline comment to more accurately reflect the purpose of the property and notes that setting system properties outside of a try block can lead to state leakage if initialization fails, recommending a safer setup pattern.
...va/server_aws_common/src/test/java/io/athenz/syncer/aws/common/impl/S3ClientFactoryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Benjamin Huff <benjaminehuff@gmail.com>
Bhuff1
force-pushed
the
feature/aws_region_default_unit_test
branch
from
b370149 to
2af7090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unit test does not receive default
us-west-2region and fails due to EC2 IMDS. Addresses issue created here.Contribution Checklist: