Skip to content

bugfix/windows crash #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Havunen merged 3 commits into from
Apr 1, 2026
+43 −34
Merged

bugfix/windows crash #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1e67e9
Use rundl32 for more stable error reporting
Havunen Apr 1, 2026
8a18444
set 8mb stack size in windows
Havunen Apr 1, 2026
263b75b
update deps
Havunen Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 31 additions & 32 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion crates/gitcomet-ui-gpui/src/view/platform_open.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,12 @@ fn open_with_default(arg: &str) -> Result<(), io::Error> {

#[cfg(target_os = "windows")]
{
let _ = std::process::Command::new("explorer.exe")
// `explorer.exe <url>` can fall back to opening the current folder for
// long query-heavy URLs on Windows. Route URLs through the shell's
// protocol handler instead so GitHub issue links reliably open in the
// default browser.
let _ = std::process::Command::new("rundll32.exe")
.arg("url.dll,FileProtocolHandler")
.arg(arg)
.spawn()?;
Ok(())
Expand Down
7 changes: 6 additions & 1 deletion scripts/windows/msvc-linker.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ set "LIB=%MSVC_LIB%;%SDK_UM_LIB%;%SDK_UCRT_LIB%;%LIB%"
set "LIBPATH=%MSVC_LIB%;%SDK_UM_LIB%;%SDK_UCRT_LIB%;%LIBPATH%"
set "INCLUDE=%MSVC_INCLUDE%;%SDK_SHARED_INC%;%SDK_UM_INC%;%SDK_UCRT_INC%;%SDK_WINRT_INC%;%SDK_CPPWINRT_INC%;%INCLUDE%"

"%LINK_EXE%" %*
rem GitComet's GPUI diff/render paths are substantially deeper in debug builds.
rem The Windows default 1 MiB main-thread stack is not enough there, which can
rem abort the process with a stack overflow before Rust's panic hook runs.
if "%GITCOMET_LINK_STACK_RESERVE%"=="" set "GITCOMET_LINK_STACK_RESERVE=8388608"

"%LINK_EXE%" /STACK:%GITCOMET_LINK_STACK_RESERVE% %*
set "EXITCODE=%ERRORLEVEL%"
exit /b %EXITCODE%
Loading