Conversation
Jay-o-Way
requested review from
a team,
Armin2208 and
Spiritreader
as code owners
| </data> | ||
| <data name="StartWithWindowsFailed_Content" xml:space="preserve"> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows again, please go to Windows Settings > Apps > Startup and enable it.</value> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows, go to Windows Settings > Apps > Startup.</value> |
There was a problem hiding this comment.
Maybe we could turn this into a clickable link?
There was a problem hiding this comment.
Here is a dialog, and it is ready to jump. So we should not need other changes.
private async void OpenAutostartSettings()
{
await Windows.System.Launcher.LaunchUriAsync(new Uri("ms-settings:startupapps"));
}There was a problem hiding this comment.
LOL we already have a button in the dialog.
ChenYiLins
added
area-UX
| </data> | ||
| <data name="AdaptiveTaskbarAccent" xml:space="preserve"> | ||
| <value>Use Taskbar Accent Color during</value> | ||
| <value>Use taskbar accent color during</value> |
There was a problem hiding this comment.
Taskbar is a name of an UI element. In english you write all names with an uppercase letter.
| <value>Theme switch pending</value> | ||
| </data> | ||
| <data name="Msg_ThemeError" xml:space="preserve"> | ||
| <value>Warning: We couldn't read your current theme.</value> |
There was a problem hiding this comment.
Not used in the solution, indeed
| <value>Select a theme</value> | ||
| </data> | ||
| <data name="PickTheme_Description" xml:space="preserve"> | ||
| <value>Select a different Windows theme for dark and light mode respectively. Allows full theme customization, but requires you to set up .theme files.</value> |
There was a problem hiding this comment.
Why should you remove this sentence explaining the hustle of this option?
There was a problem hiding this comment.
I thought the UX would be clear enough. There's a longer description on that page already.
Also: now it's one sentence that doesn't need a period at the end
| <value>Let Windows manage my theme</value> | ||
| </data> | ||
| <data name="UpdateAtStart" xml:space="preserve"> | ||
| <value>Check when Auto Dark Mode starts</value> |
There was a problem hiding this comment.
Even Windows uses "Check" for updates and not "Searching". Gemini recommends me using "Check"
| </data> | ||
| <data name="StartWithWindowsFailed_Content" xml:space="preserve"> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows again, please go to Windows Settings > Apps > Startup and enable it.</value> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows, go to Windows Settings > Apps > Startup.</value> |
| <value>Windows colors</value> | ||
| </data> | ||
| <data name="Msg_AutomaticColorModeDescription" xml:space="preserve"> | ||
| <value>Automatic accent color is selected. The color will be determined by the current wallpaper</value> |
There was a problem hiding this comment.
Sorry, I just thought it was way too obvious, explaining what "automatic color" means?
| <value>Automatically switches the theme based on environment lighting</value> | ||
| </data> | ||
| <data name="AmbientLightSensor_Unavailable_ToolTip" xml:space="preserve"> | ||
| <value>This feature isn't available on your device because no ambient light sensor was detected</value> |
There was a problem hiding this comment.
Just keeping it simple.
Also, I think words like "you(r)" and "we" are not appropriate in UI.
|
PRs like this improve tiny things, but some small things are actually intended. So this Pull Request needs many discussions (with me) which makes stuff like that hard to commit. |
4 participants
Simplified a few strings and even deleted a few.
Reverted UX to
SettingsCard IsEnabled="{x:Bind ViewModel.AutoThemeSwitchingEnabled