Correct shardkey access in buildBulkWriteOps#14752
Merged
vkarpov15 merged 1 commit intoAutomattic:masterfrom Jul 19, 2024
Merged
Correct shardkey access in buildBulkWriteOps#14752vkarpov15 merged 1 commit intoAutomattic:masterfrom
vkarpov15 merged 1 commit intoAutomattic:masterfrom
Conversation
buildBulkWriteOperations adds the shard key to the filter condition, but it sets it to the schema's value, not the document's value. It also updates a problematic test, which passed because the update value it uses was the same schema's shard key value.
2 tasks
Collaborator
|
We don't backport fixes to previous minor release lines unless there's a good reason to. Is it ok if we release this in 8.5.2? |
vkarpov15
approved these changes
Jul 19, 2024
Contributor
Author
|
@vkarpov15 thanks for the prompt action here! Re backporting: That's fair, releasing in 8.5.2 will be great 👍 |
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
This was referenced Sep 11, 2024
This was referenced Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14753
Summary
buildBulkWriteOperations adds the shard key to the filter condition, but it sets it to the schema's value, not the document's value.
This PR also updates a problematic test, which passed because the update value it uses was the same schema's shard key value.
Also, not sure about the backport policy, but we might need to get this ported to the minor version. It was broken in 8.4.1