Skip to content

Move all submodules to external directory#18431

Merged
MrJul merged 5 commits intoAvaloniaUI:masterfrom
MrJul:move-submodules
Mar 13, 2025
Merged

Move all submodules to external directory#18431
MrJul merged 5 commits intoAvaloniaUI:masterfrom
MrJul:move-submodules

Conversation

@MrJul
Copy link
Member

@MrJul MrJul commented Mar 12, 2025

What does the pull request do?

This PR moves all submodules to a common external folder.
This is done to avoid any unexpected issue occurring by having submodules in the src folder.

@MrJul MrJul added enhancement area-infrastructure Issues related to CI/tooling infrastructur labels Mar 12, 2025
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0055514-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul force-pushed the move-submodules branch from d3fe23f to 7732da7 Compare March 13, 2025 12:58
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0055522-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0055524-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Mar 13, 2025
Merged via the queue into AvaloniaUI:master with commit c925ca5 Mar 13, 2025
10 checks passed
@MrJul MrJul deleted the move-submodules branch March 13, 2025 18:23
@MrJul MrJul mentioned this pull request Mar 22, 2025
3 tasks
@MrJul
Copy link
Member Author

MrJul commented Mar 22, 2025

Trouble may arise when pulling changes after this PR.

First, make sure the submodules are updated:
git submodule update --init --recursive

Git may not correctly remove some old submodule folders ("unable to rmdir 'src/Avalonia.Controls.DataGrid': Directory not empty")

If the warning above appears, or if you've got duplicated symbol errors when building, clean your working directory and all submodules:
git clean -ffxd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Issues related to CI/tooling infrastructur enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants