Skip to content

Fix ObjectDisposedException in Cancellation token access (#19)#20

Merged
SKProCH merged 1 commit intoAvaloniaUtils:masterfrom
ionite34:patch-1
Sep 25, 2023
Merged

Fix ObjectDisposedException in Cancellation token access (#19)#20
SKProCH merged 1 commit intoAvaloniaUtils:masterfrom
ionite34:patch-1

Conversation

@ionite34
Copy link
Copy Markdown
Contributor

@ionite34 ionite34 commented Sep 25, 2023

Changes:

  • ignore ObjectDisposed exceptions during canceling of oldCancellationToken
  • no longer dispose oldCancellationToken since it may be being used in another call
  • instead we dispose the token source the current method created in a finally clause of the task

@ionite34 ionite34 mentioned this pull request Sep 25, 2023
Closed
SKProCH
SKProCH approved these changes Sep 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SKProCH SKProCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks!

@SKProCH SKProCH merged commit 7c543ab into AvaloniaUtils:master Sep 25, 2023
@SKProCH
Copy link
Copy Markdown
Member

SKProCH commented Sep 25, 2023

I will publish a new version the next day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SKProCH SKProCH SKProCH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ionite34 @SKProCH