Skip to content

feat(cli): warning if contract crate has tests#20723

Merged
benesjan merged 6 commits intomerge-train/fairiesfrom
02-20-feat_cli_asserting_that_contract_crates_have_no_tests
Feb 24, 2026
Merged

feat(cli): warning if contract crate has tests#20723
benesjan merged 6 commits intomerge-train/fairiesfrom
02-20-feat_cli_asserting_that_contract_crates_have_no_tests

Conversation

@benesjan
Copy link
Copy Markdown
Contributor

@benesjan benesjan commented Feb 20, 2026

We assert that contract crate has no tests to force devs to put them into the test crate. If this was not done this would result in their contracts constantly recompiling when only modifying tests which would be super slow and they would have no clue why.

Closes https://linear.app/aztec-labs/issue/F-196/check-contract-crates-do-not-contain-tests

Copy link
Copy Markdown
Contributor Author

benesjan commented Feb 20, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan changed the title feat(cli): asserting that contract crates have no tests feat(cli): warning if contract crate has tests Feb 21, 2026
@benesjan benesjan force-pushed the 02-20-feat_cli_asserting_that_contract_crates_have_no_tests branch from c23a37d to 05bbbf0 Compare February 21, 2026 10:40
@benesjan benesjan marked this pull request as ready for review February 21, 2026 10:40
@benesjan benesjan force-pushed the 02-20-feat_cli_asserting_that_contract_crates_have_no_tests branch 2 times, most recently from f9b122d to fc7e946 Compare February 23, 2026 15:11
@benesjan benesjan requested a review from nchamo February 23, 2026 16:23
@benesjan benesjan force-pushed the 02-20-feat_cli_asserting_that_contract_crates_have_no_tests branch from d3a3170 to 11d8d00 Compare February 23, 2026 16:25
Copy link
Copy Markdown
Contributor

@nchamo nchamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Comment thread yarn-project/aztec/src/cli/cmds/compile.ts
Comment thread yarn-project/aztec/src/cli/cmds/compile.ts
Comment thread docs/docs-developers/docs/aztec-nr/testing_contracts.md
Comment thread docs/netlify.toml
Comment thread yarn-project/aztec/src/cli/cmds/compile.ts
@benesjan benesjan enabled auto-merge (squash) February 24, 2026 04:20
@benesjan benesjan merged commit 7f4bfa5 into merge-train/fairies Feb 24, 2026
11 checks passed
@benesjan benesjan deleted the 02-20-feat_cli_asserting_that_contract_crates_have_no_tests branch February 24, 2026 04:32
github-merge-queue Bot pushed a commit that referenced this pull request Feb 24, 2026
BEGIN_COMMIT_OVERRIDE
feat(cli): warning if contract crate has tests (#20723)
END_COMMIT_OVERRIDE
benesjan added a commit that referenced this pull request Apr 16, 2026
## Summary

Backports 6 PRs with aztec CLI improvements from `next` to `v4-next`:

- #20681 - refactor: aztec new and init creating 2 crates
- #20711 - test: aztec new scaffold works
- #20723 - feat(cli): warning if contract crate has tests
- #20729 - feat(cli): auto-recompiling when aztec test is run
- #21007 - feat: aztec new supporting multiple contract crates
- #21245 - feat: asserts that aztec dep version matches cli
@benesjan
Copy link
Copy Markdown
Contributor Author

Backported to v4-next in #22587

Thunkar added a commit that referenced this pull request Apr 17, 2026
BEGIN_COMMIT_OVERRIDE
fix(pxe): cap event filter toBlock to last synced block (#22573)
fix(pxe): round tx expiration timestamp to reduce precision (#22577)
fix: eliminate anvil watcher warp race and false success logs (#22584)
refactor: aztec new and init creating 2 crates (#20681)
test: aztec new scaffold works (#20711)
feat(cli): warning if contract crate has tests (#20723)
feat(cli): auto-recompiling when aztec test is run (#20729)
feat: aztec new supporting multiple contract crates (#21007)
feat: asserts that aztec dep version matches cli (#21245)
chore: backport aztec CLI improvements to v4-next (#22587)
feat: check noir release has nargo binaries before releasing (#22551)
chore: cache chainInfo in embeddedwallet (#22592)
fix: wrap external getCapsule in transactionAsync (#22595)
fix(pxe): throw clear error for invalid comparator in pick_notes
(#22585)
refactor(aztec-nr): rename conversion fns to encode_/decode_ naming
(#22576)
feat: infrastructure for testing `[new_contract_artfiacts,
old_aztec_stack]` (#22593)
chore: fix unnecessary and inconsistent side-effect counter increments
(#22245)
fix: update FaceID wallet redirects and strip anchors in redirect
validation (#22505)
docs: add getting started on testnet guide (#22366)
docs: add getting started on testnet guide (backport #22366) (#22619)
feat(aztec-nr): new BoundedVec emit private log APIs (#22064)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants