Skip to content

fix: not reusing tags of partially reverted txs (backport #20817)#21584

Merged
benesjan merged 1 commit intobackport-to-v4-next-stagingfrom
claudebox/backport-20817-v4-next
Mar 16, 2026
Merged

fix: not reusing tags of partially reverted txs (backport #20817)#21584
benesjan merged 1 commit intobackport-to-v4-next-stagingfrom
claudebox/backport-20817-v4-next

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented Mar 16, 2026

Summary

Backport of #20817 to v4-next.

Cherry-pick of merge commit 797709145ffa409c9eb40643e9be78f1b3d054c6 rebased onto backport-to-v4-next-staging. Two minor conflicts resolved:

  • private_execution.ts: Kept v4's offchainEffects.map(e => ({ data: e.data })) mapping with fix: not reusing tags of partially reverted txs #20817's taggingIndexRanges rename
  • private_execution_oracle.ts: Dropped redundant getOffchainEffects() override (already in base class), updated JSDoc

Changes

Prevents reusing tags of partially reverted txs by:

  • Checking if a tx was finalized and partially reverted
  • Obtaining the tx effect from chain and recomputing siloed tags to match which indexes actually made it onchain
  • Changing the data model from tracking only the highest used index to tracking the full range of indexes

Original PR

#20817 by @benesjan

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 16, 2026
@AztecBot AztecBot force-pushed the claudebox/backport-20817-v4-next branch from d6ac968 to 8eff75e Compare March 16, 2026 11:07
Copy link
Copy Markdown
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good

@benesjan benesjan marked this pull request as ready for review March 16, 2026 11:20
@AztecBot
Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/c13e9d6f2af4a8ce�c13e9d6f2af4a8ce8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "proposer invalidates previous block with shuffled attestations" (155s) (code: 0) group:e2e-p2p-epoch-flakes

@benesjan benesjan merged commit 320fccd into backport-to-v4-next-staging Mar 16, 2026
15 checks passed
@benesjan benesjan deleted the claudebox/backport-20817-v4-next branch March 16, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants