fix(aztec-up): always reinstall noirup and foundryup bootstrappers#21826
Conversation
I assume |
They have releases, but you can't run If not, different users would have different experiences, based on their previous setup |
|
✅ Successfully backported to backport-to-v4-next-staging #22075. |
BEGIN_COMMIT_OVERRIDE fix(aztec-up): always reinstall noirup and foundryup bootstrappers (#21826) fix(aztec-up): show installed version after install (#21822) feat(aztec-up): default install version to latest instead of nightly (backport #21883) (#22076) feat(aztec-up): auto-update before install with staleness check (#21866) cherry-pick: feat(aztec-up): add versioned aliases for multi-major version support (#21817) feat(aztec-up): add versioned aliases for multi-major version support (backport #21817) (#22080) feat(aztec-up): decouple infra assets from toolchain VERSION (backport #22078) (#22079) feat: backport hardcode version into install scripts at release time (#22082) fix(aztec-up): pass VERSION to per-version installer and fix release sed (#22083) END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE feat(aztec-up): default install version to latest instead of nightly (#21883) fix(aztec-up): always reinstall noirup and foundryup bootstrappers (#21826) fix(aztec-up): show installed version after install (#21822) feat(aztec-up): decouple infra assets from toolchain VERSION (#22078) feat(aztec-up): add versioned aliases for multi-major version support (#21817) feat(aztec-up): auto-update before install with staleness check (#21866) fix(aztec-up): pass VERSION to per-version installer and fix release sed (#22083) feat: asserts that aztec dep version matches cli (#21245) END_COMMIT_OVERRIDE
Problem
aztec-up installskipped re-downloadingnoirupandfoundryupif they were already present on the user's machine. This meant returning users kept stale bootstrappers while new users got the latest ones.When
noirupgained support for downloadingnoir-profiler, users with an oldnoiruphit a hard failure atmv noir-profiler(the binary was never fetched). Existing users broke; new users didn't.Fix
Remove the conditional guards around both bootstrapper installs. Every
aztec-up installnow unconditionally re-curlsnoirupandfoundryupinstall scripts, ensuring every user ends up with the same bootstrappers versions regardless of prior state. The ~2-5s overhead is negligible compared to the rest of the install.Fixes F-471