Skip to content

fix(aztec-up): always reinstall noirup and foundryup bootstrappers#21826

Merged
nchamo merged 1 commit intomerge-train/fairiesfrom
fix/aztec-up-always-update-bootstrappers
Mar 26, 2026
Merged

fix(aztec-up): always reinstall noirup and foundryup bootstrappers#21826
nchamo merged 1 commit intomerge-train/fairiesfrom
fix/aztec-up-always-update-bootstrappers

Conversation

@nchamo
Copy link
Copy Markdown
Contributor

@nchamo nchamo commented Mar 19, 2026

Problem

aztec-up install skipped re-downloading noirup and foundryup if they were already present on the user's machine. This meant returning users kept stale bootstrappers while new users got the latest ones.

When noirup gained support for downloading noir-profiler, users with an old noirup hit a hard failure at mv noir-profiler (the binary was never fetched). Existing users broke; new users didn't.

Fix

Remove the conditional guards around both bootstrapper installs. Every aztec-up install now unconditionally re-curls noirup and foundryup install scripts, ensuring every user ends up with the same bootstrappers versions regardless of prior state. The ~2-5s overhead is negligible compared to the rest of the install.

Fixes F-471

@nchamo nchamo requested a review from charlielye as a code owner March 19, 2026 23:08
@nchamo nchamo self-assigned this Mar 19, 2026
@nchamo nchamo requested a review from nventuro March 19, 2026 23:21
@nventuro
Copy link
Copy Markdown
Contributor

users with an old noirup hit a hard failure at mv noir-profiler (the binary was never fetched)

I assume noirup also has no notion of versioning?

@nchamo
Copy link
Copy Markdown
Contributor Author

nchamo commented Mar 20, 2026

users with an old noirup hit a hard failure at mv noir-profiler (the binary was never fetched)

I assume noirup also has no notion of versioning?

They have releases, but you can't run noirup --version and see what version you have installed. I considered using commit hashes to force a specific version, but then we would need to release a new aztec-up version to update the noirup version. Wouldn't be too bad, but since it's a manual process I thought it just made sense for all users to run with the latest version

If not, different users would have different experiences, based on their previous setup

Base automatically changed from merge-train/fairies to next March 26, 2026 04:08
@nchamo nchamo changed the base branch from next to merge-train/fairies March 26, 2026 18:01
@nchamo nchamo merged commit 0825643 into merge-train/fairies Mar 26, 2026
19 checks passed
@nchamo nchamo deleted the fix/aztec-up-always-update-bootstrappers branch March 26, 2026 18:12
@AztecBot
Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v4-next-staging #22075.

AztecBot added a commit that referenced this pull request Mar 27, 2026
BEGIN_COMMIT_OVERRIDE
fix(aztec-up): always reinstall noirup and foundryup bootstrappers
(#21826)
fix(aztec-up): show installed version after install (#21822)
feat(aztec-up): default install version to latest instead of nightly
(backport #21883) (#22076)
feat(aztec-up): auto-update before install with staleness check (#21866)
cherry-pick: feat(aztec-up): add versioned aliases for multi-major
version support (#21817)
feat(aztec-up): add versioned aliases for multi-major version support
(backport #21817) (#22080)
feat(aztec-up): decouple infra assets from toolchain VERSION (backport
#22078) (#22079)
feat: backport hardcode version into install scripts at release time
(#22082)
fix(aztec-up): pass VERSION to per-version installer and fix release sed
(#22083)
END_COMMIT_OVERRIDE
github-merge-queue Bot pushed a commit that referenced this pull request Mar 27, 2026
BEGIN_COMMIT_OVERRIDE
feat(aztec-up): default install version to latest instead of nightly
(#21883)
fix(aztec-up): always reinstall noirup and foundryup bootstrappers
(#21826)
fix(aztec-up): show installed version after install (#21822)
feat(aztec-up): decouple infra assets from toolchain VERSION (#22078)
feat(aztec-up): add versioned aliases for multi-major version support
(#21817)
feat(aztec-up): auto-update before install with staleness check (#21866)
fix(aztec-up): pass VERSION to per-version installer and fix release sed
(#22083)
feat: asserts that aztec dep version matches cli (#21245)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants