fix(e2e): set anvilSlotsInAnEpoch in slashing tests#21869
Merged
spalladino merged 1 commit intomerge-train/spartanfrom Mar 26, 2026
Merged
fix(e2e): set anvilSlotsInAnEpoch in slashing tests#21869spalladino merged 1 commit intomerge-train/spartanfrom
spalladino merged 1 commit intomerge-train/spartanfrom
Conversation
With the default slotsInAnEpoch=1, anvil reports finalized = latest - 2, causing L1 finalization to race ahead of L2 checkpoint processing. The P2P client prunes its attestation pool on finalization, which can delete attestations for a slot before the sentinel has a chance to read them, leading to false attestation-missed reports. Setting anvilSlotsInAnEpoch=4 (finalized = latest - 8) gives the sentinel enough time to query the P2P pool before it is pruned. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
spalladino
changed the title
spalladino
added
ci-no-fail-fast
PhilWindle
approved these changes
Mar 26, 2026
Collaborator
|
❌ Failed to cherry-pick to |
spalladino
added a commit
that referenced
this pull request
Mar 27, 2026
Resolves conflicts from cherry-picking PRs #21829, #21853, #21869, #22023. Key resolutions: - start_anvil.ts: take full rewrite from PR #21829 (spawn-based instead of @viem/anvil) - sequencer-publisher.ts: use getNextL1SlotTimestamp with pipelining (PR #21853), getSimulationTimestamp for simulation timestamps (PR #22023), add aztecSlotDuration property - setup.ts: add slotsInAnEpoch and dateProvider options - slasher_config.test.ts: add anvilSlotsInAnEpoch option - checkpoint_voter test: add epochCache mock methods - Drop backupFailedTx calls (infrastructure not on this branch)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
BEGIN_COMMIT_OVERRIDE fix: only clear provenBlockNumber when it exceeds prune point (#21946) chore: (A-779) load all accounts before calling LogService.#getSecretsForSenders (#21923) fix: align staging-public mana target with testnet/mainnet (#21983) chore: (A-777) add warn logs for regressive path in block synchronizer (#21925) fix: fully validate txs retrieved from tx file store (#21988) refactor: extract checkpoint proposal handling to ProposalHandler (#21999) fix: unbounded memory in calldataRetriever (#22004) fix(p2p): check peer rate limit before global to prevent quota starvation (#21997) fix(p2p): evict expired failed-auth-handshake entries on heartbeat (#21992) chore: defensively handle skipPushProposedBlocksToArchiver (#22017) chore: bump testnet prover resource profile to prod-hi-tps (#22019) chore: (A-835) remove unused serializer (#22037) fix(p2p): remove disconnected peers from scoring maps (#22009) fix(e2e): set anvilSlotsInAnEpoch in slashing tests (#21869) fix(ethereum): Audit fixes A-810, A-812 (nonce race, isEscapeHatchOpen logging) (#21948) chore: remove old TxPool implementation (#22028) fix: Fix blob encoding when uploaded from proposals (#22045) chore: Adds /cycle and /fix skills. Also configures linear mcp server (#22043) chore: remove validatorReexecute config option (#22024) fix(sequencer): use last L1 slot of L2 slot as eth_simulateV1 timestamp (#22023) docs(simulator): clarify teardown gas billing is intentional (#22057) chore: revert account loading optimization in log service (#22062) fix: use DateProvider in PeerScoring (#22070) fix(aztec.js): preserve extraHashedArgs in DeployMethod.with() (#22053) fix(p2p): replace process.exit() with graceful shutdown in worker cleanup (#22046) chore: merge next (#22089) fix(stdlib): correct NoteDao size (#22068) feat: improve blob download from filestores (#22096) fix: remove stale tx_pool v1 benchmark reference (#22104) END_COMMIT_OVERRIDE
spalladino
added a commit
that referenced
this pull request
Mar 30, 2026
## Backport PRs to `backport-to-v4-next-staging` Cherry-picked the following PRs (in order) on top of the branch, committing each with conflicts unresolved: 1. **#21829** - `fix: sync dateProvider from anvil stdout on every mined block` 2. **#21853** - `fix(sequencer): remove l1 block timestamp check` 3. **#21869** - `fix(e2e): set anvilSlotsInAnEpoch in slashing tests` 4. **#22023** - `fix(sequencer): use last L1 slot of L2 slot as eth_simulateV1 timestamp` ### Conflict resolution Added a single commit resolving all cherry-pick conflicts: - **`yarn-project/ethereum/src/test/start_anvil.ts`**: Took the full rewrite from PR #21829, replacing the `@viem/anvil`-based implementation with a direct `child_process.spawn` approach. Updated `start_anvil.test.ts` to import the new local `Anvil` type instead of `@viem/anvil`. - **`yarn-project/end-to-end/src/fixtures/setup.ts`**: Added `slotsInAnEpoch` and `dateProvider` options to the `startAnvil` call. - **`yarn-project/end-to-end/src/e2e_sequencer/slasher_config.test.ts`**: Added `anvilSlotsInAnEpoch: 4` option to the `setup` call. - **`yarn-project/sequencer-client/src/sequencer/checkpoint_voter.ha.integration.test.ts`**: Added `epochCache.getSlotNow` and `epochCache.getL1Constants` mock return values. - **`yarn-project/sequencer-client/src/publisher/sequencer-publisher.ts`**: - `canProposeAt`: Replaced `getNextL1SlotTimestampWithL1Floor()` with `getNextL1SlotTimestamp()` plus pipelining offset (PR #21853). Added `pipelined?: boolean` to the opts type. - `validateCheckpointForSubmission`: Changed return type to `Promise<void>`, removed manual timestamp computation (PR #22023). - `enqueueCastSignalHelper` / `simulateProposeTx`: Use `getSimulationTimestamp()` for simulation timestamps, improved error logging with `formatViemError` (PR #22023). - Added `aztecSlotDuration` class property and wired it through the config. - Dropped `backupFailedTx` calls since the underlying `FailedL1Tx` / `createL1TxFailedStore` infrastructure does not exist on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default
slotsInAnEpoch=1, anvil finalizes blocks almost immediately (finalized = latest - 2). This causes the P2P client to prune its attestation pool before the sentinel gets a chance to read it, leading to falseattestation-missedflakes in sentinel and slashing tests. Bumps to 4 so finalization doesn't race ahead of sentinel processing.🤖 Generated with Claude Code