Skip to content

chore: Fix nightly debug vk check#21957

Merged
federicobarbacovi merged 2 commits intomerge-train/barretenbergfrom
fb/fix_nightly_debug_vk_check
Mar 24, 2026
Merged

chore: Fix nightly debug vk check#21957
federicobarbacovi merged 2 commits intomerge-train/barretenbergfrom
fb/fix_nightly_debug_vk_check

Conversation

@federicobarbacovi
Copy link
Copy Markdown
Contributor

The Chonk standalone vk check was failing because:

  • The native preset was not used to resolve bb (so we were resolving build/bin/bb instead of build-debug/bin/bb)
  • The VK check did not disable asserts (so when checking VKs we would detect mismatches due to the dummy data supplied to build VKs)

This PR fixes the above issues:

  • Resolve bb using the script preset-build-dir with argument NATIVE_PRESET
  • Add a flag to the check command in the bb api that disables asserts when checking vks

@federicobarbacovi federicobarbacovi marked this pull request as ready for review March 24, 2026 14:54
@federicobarbacovi federicobarbacovi enabled auto-merge (squash) March 24, 2026 15:08
@federicobarbacovi federicobarbacovi merged commit b15d7f2 into merge-train/barretenberg Mar 24, 2026
23 checks passed
@federicobarbacovi federicobarbacovi deleted the fb/fix_nightly_debug_vk_check branch March 24, 2026 16:33
github-merge-queue Bot pushed a commit that referenced this pull request Mar 24, 2026
BEGIN_COMMIT_OVERRIDE
fix: use llvm-objdump-20 for Mach-O re-signing in version injection
(#21953)
chore: Fix nightly debug vk check (#21957)
feat: SRS point compression - download 50% less CRS data (#21112)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants