fix: add pull-requests write permission to ci-external workflow#21965
Merged
fix: add pull-requests write permission to ci-external workflow#21965
Conversation
The ci-external workflow's `gh pr edit --remove-label "ci-external-once"` fails with "Resource not accessible by integration" because the default github.token has read-only permissions when no permissions block is set. This adds explicit permissions (contents: read, pull-requests: write) to the ci-external job, matching the pattern used by other label-modifying workflows in the repo. Safe because the workflow runs via pull_request_target (code from base branch) and is gated by a maintainer adding the ci-external label.
johnathan79717
added
ci-external-once
ludamad
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-externalworkflow fails withResource not accessible by integration (removeLabelsFromLabelable)becausegithub.tokendefaults to read-only when nopermissionsblock is set.contents: read+pull-requests: writeto theci-externaljob sogh pr edit --remove-label "ci-external-once"can succeed.Context
pull_request_target(code always from base branch, not fork) and is gated by a maintainer adding theci-external/ci-external-oncelabel.merge-train-create-pr,auto-close-stale-drafts).