Skip to content

fix(pxe): robust error handling in message processing (backport #21093)#21981

Merged
benesjan merged 2 commits intobackport-to-v4-next-stagingfrom
claudebox/backport-21093-v4-next
Mar 25, 2026
Merged

fix(pxe): robust error handling in message processing (backport #21093)#21981
benesjan merged 2 commits intobackport-to-v4-next-stagingfrom
claudebox/backport-21093-v4-next

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Summary

Backport of #21093 to v4-next.

Cherry-pick of c02d4a4 with conflict resolution.

Conflict resolution

The only conflict was in noir-projects/aztec-nr/aztec/src/messages/discovery/private_notes.nr — the import block had a different structure on v4-next (separate use statements) vs next (combined use crate::{...} block). Resolved by taking the PR's restructured imports which add the aztecnr_warn_log_format and ToField imports needed by the new warning/debug logging code.

Changes from original PR

  • Improved error messages in NoteService and EventService with more context about why errors occur
  • EventService now logs a warning and skips (instead of throwing) when event commitment is not in tx — prevents malicious messages from bricking PXE
  • Added warn logging in Noir for private note messages that don't match any note hash
  • Removed stale debug log from nonce_discovery.nr

ClaudeBox log: https://claudebox.work/s/cbd367efcc636e8d?run=1

benesjan and others added 2 commits March 25, 2026 01:26
Resolved import conflict in private_notes.nr by taking the incoming version which restructures imports into a single use block and adds aztecnr_warn_log_format and ToField imports needed by the new code.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 25, 2026
@benesjan benesjan marked this pull request as ready for review March 25, 2026 01:41
@benesjan benesjan requested a review from nventuro as a code owner March 25, 2026 01:41
@benesjan benesjan enabled auto-merge (squash) March 25, 2026 01:42
@benesjan benesjan merged commit b2773c8 into backport-to-v4-next-staging Mar 25, 2026
20 of 26 checks passed
@benesjan benesjan deleted the claudebox/backport-21093-v4-next branch March 25, 2026 01:58
AztecBot added a commit that referenced this pull request Mar 25, 2026
BEGIN_COMMIT_OVERRIDE
fix(aztec-up): narrow PATH cleanup regex to avoid removing user PATH
entries (#21828)
fix: consolidate blob source test into single summary log with supernode
detection (#21719)
fix: use anchor block on getL1ToL2MsgWitness (#21872)
fix: make sure queries are not made ahead of the anchor block (#21874)
chore(docs): backport docs infrastructure changes to v4 (#21437)
chore: backport PR #21836 (fix: explicitly handle initial block case for
getBlockHashMembershipWitness) to v4-next (#21891)
chore: backport PR #21813 (fix(aztec-up): strip leading v prefix from
version strings) to v4-next (#21912)
docs: document defi-wonderland immutable macro (#21764)
fix: pin typescript and harden lockfile check in docs examples CI (v4
backport) (#21914)
docs: expand circuit profiling guide and document kernel gate cost
overhead (#21770)
feat: cli-wallet (#21757)
chore: sync backport staging with v4-next HEAD (#21931)
fix: bot gas estimations (backport #21945) (#21947)
refactor(aztec-nr): use logging wrappers in
compute_note_hash_and_nullifier (#21897)
fix: backport v4 next staging (#21934)
fix: make PXE#getSyncedBlockHeader a concurrency=1 job to prevent IDB tx
liveness issues (#21944)
feat: add error page mapping for incompatible oracles (#21943)
fix(aztec-up): validate semver in uninstall to prevent path traversal
(#21892)
chore: merge v4-next into backport staging (fix ancestry) (#21954)
fix(aztec-up): add truncation protection to install scripts (#21896)
fix: noir format in compute_note_hash_and_nullifier.nr (#21956)
fix(stdlib): decode `EthAddress`, `FunctionSelector` and wrapped field
structs in `AbiDecoder` (#21926)
chore: update noir to nightly-2026-02-12-patch.1 (#21960)
fix: ensure empty docs examples does not populate yarn lock backport
(#21963)
fix: docs examples does not build on simple bootstrap backport (#21964)
fix: add rc/testnet version detection to API reference pages (#21966)
docs: document EmbeddedWallet automatic gas estimation and private
authwits (#21790)
fix(pxe): robust error handling in message processing (backport #21093)
(#21981)
chore: manually recreate backport (#21969)
chore: (A-779) load all accounts before calling
LogService.#getSecretsForSenders (#21923)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants