Skip to content

fix: deploy-staging-public waits for any semver tag instead of release-please version#21984

Merged
PhilWindle merged 1 commit intonextfrom
claudebox/fix-staging-deploy-semver-tag
Mar 25, 2026
Merged

fix: deploy-staging-public waits for any semver tag instead of release-please version#21984
PhilWindle merged 1 commit intonextfrom
claudebox/fix-staging-deploy-semver-tag

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Summary

Since we've stopped using release-please, the deploy-staging-public workflow was broken — it read the version from .release-please-manifest.json and waited for a tag matching that exact version.

This PR removes the release-please manifest dependency and instead:

  • Polls for any valid semver tag at HEAD using ci3/semver check
  • If multiple semver tags exist, picks the highest using ci3/semver sort

Changes

The updated workflow is in .github-new/workflows/deploy-staging-public.yml and needs to be moved to .github/workflows/deploy-staging-public.yml before merging.

  • Removed the "Read version from manifest" step entirely
  • Replaced the tag-matching grep with ci3/semver check validation
  • Uses ci3/semver sort to pick the highest tag when multiple exist

ClaudeBox log: https://claudebox.work/s/43c486478ab3e16b?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 25, 2026
@alexghr alexghr marked this pull request as ready for review March 25, 2026 08:43
@alexghr alexghr requested a review from charlielye as a code owner March 25, 2026 08:43
…e-please version

## Summary
Since we've stopped using release-please, the `deploy-staging-public` workflow was broken — it read the version from `.release-please-manifest.json` and waited for a tag matching that exact version.

This PR removes the release-please manifest dependency and instead:
- Polls for **any valid semver tag** at HEAD using `ci3/semver check`
- If multiple semver tags exist, picks the highest using `ci3/semver sort`

## Changes
The updated workflow is in `.github-new/workflows/deploy-staging-public.yml` and needs to be moved to `.github/workflows/deploy-staging-public.yml` before merging.

- Removed the "Read version from manifest" step entirely
- Replaced the tag-matching grep with `ci3/semver check` validation
- Uses `ci3/semver sort` to pick the highest tag when multiple exist

ClaudeBox log: https://claudebox.work/s/43c486478ab3e16b?run=1

Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
@AztecBot AztecBot force-pushed the claudebox/fix-staging-deploy-semver-tag branch from 0324c08 to 82beed0 Compare March 25, 2026 08:45
@AztecBot AztecBot enabled auto-merge March 25, 2026 08:45
@AztecBot AztecBot added this pull request to the merge queue Mar 25, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026
@PhilWindle PhilWindle added this pull request to the merge queue Mar 25, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026
@PhilWindle PhilWindle added this pull request to the merge queue Mar 25, 2026
@AztecBot
Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/a2c4590900c3a63c�a2c4590900c3a63c8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_offchain_payment.test.ts (55s) (code: 0)

Merged via the queue into next with commit ecd12c5 Mar 25, 2026
22 checks passed
@PhilWindle PhilWindle deleted the claudebox/fix-staging-deploy-semver-tag branch March 25, 2026 23:07
AztecBot pushed a commit that referenced this pull request Mar 25, 2026
…e-please version (#21984)

## Summary
Since we've stopped using release-please, the `deploy-staging-public`
workflow was broken — it read the version from
`.release-please-manifest.json` and waited for a tag matching that exact
version.

This PR removes the release-please manifest dependency and instead:
- Polls for **any valid semver tag** at HEAD using `ci3/semver check`
- If multiple semver tags exist, picks the highest using `ci3/semver
sort`

## Changes
The updated workflow is in
`.github-new/workflows/deploy-staging-public.yml` and needs to be moved
to `.github/workflows/deploy-staging-public.yml` before merging.

- Removed the "Read version from manifest" step entirely
- Replaced the tag-matching grep with `ci3/semver check` validation
- Uses `ci3/semver sort` to pick the highest tag when multiple exist

ClaudeBox log: https://claudebox.work/s/43c486478ab3e16b?run=1
@AztecBot
Copy link
Copy Markdown
Collaborator Author

✅ Successfully backported to backport-to-v4-staging #22030.

AztecBot added a commit that referenced this pull request Mar 26, 2026
BEGIN_COMMIT_OVERRIDE
fix: deploy-staging-public waits for any semver tag instead of
release-please version (#21984)
fix: Fix blob encoding when uploaded from proposals (#22045)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4 ci-skip claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants