Skip to content

refactor(aztec-nr): remove storage from init_test_contract#21996

Merged
benesjan merged 1 commit intomerge-train/fairiesfrom
fix/init-test-remove-storage
Mar 25, 2026
Merged

refactor(aztec-nr): remove storage from init_test_contract#21996
benesjan merged 1 commit intomerge-train/fairiesfrom
fix/init-test-remove-storage

Conversation

@nchamo
Copy link
Copy Markdown
Contributor

@nchamo nchamo commented Mar 25, 2026

Summary

  • init_test_contract/src/main.nr: removed Storage struct and PublicMutable/Map usage since the contract only tests initialization checks (revert vs no-revert), not storage behavior
  • Functions now return unique field values (pub_no_init_check returns 1, utility_init_check returns 2) instead of reading from storage
  • private_initialization.test.ts: updated expectations to match the new return values

Followup from #21751 (comment)

@nchamo nchamo self-assigned this Mar 25, 2026
@nchamo nchamo changed the title chore(aztec-nr): remove storage from init_test_contract refactor(aztec-nr): remove storage from init_test_contract Mar 25, 2026
@nchamo nchamo requested a review from benesjan March 25, 2026 14:09
Copy link
Copy Markdown
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@benesjan benesjan merged commit 9cf41af into merge-train/fairies Mar 25, 2026
13 checks passed
@benesjan benesjan deleted the fix/init-test-remove-storage branch March 25, 2026 14:27
@AztecBot
Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v4-next-staging #21995.

nchamo added a commit that referenced this pull request Mar 26, 2026
BEGIN_COMMIT_OVERRIDE
feat!: scoped capsules (backport #21533) (#21986)
feat(aztec-nr): add initialization check to utility functions (#21751)
refactor(aztec-nr): remove storage from init_test_contract (#21996)
fix(p2p): check peer rate limit before global to prevent quota
starvation (#21997)
chore: remove claude file (#22012)
fix: disallow infinite pubkeys (#22026)
END_COMMIT_OVERRIDE
github-merge-queue Bot pushed a commit that referenced this pull request Mar 26, 2026
BEGIN_COMMIT_OVERRIDE
feat(aztec-nr): add initialization check to utility functions (#21751)
refactor(aztec-nr): remove storage from init_test_contract (#21996)
chore: remove claude file (#22012)
refactor!: more consistent oracle names (#22018)
feat(aztec-nr)!: app-silo getSharedSecret oracle (#22020)
fix: disallow infinite pubkeys (#22026)
feat: aztecnr log prefixing (#22027)
feat(aztec-nr)!: domain-separated tags on log emission (#21910)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants