chore: (A-815) fix l1 tx utils fallback id logic#22187
Merged
PhilWindle merged 1 commit intomerge-train/spartanfrom Mar 31, 2026
Merged
chore: (A-815) fix l1 tx utils fallback id logic#22187PhilWindle merged 1 commit intomerge-train/spartanfrom
PhilWindle merged 1 commit intomerge-train/spartanfrom
Conversation
This is purely a correctness fix, no behavioral changes as the id is only used for store operations and when there is no store, this fallback is never hit.
danielntmd
changed the title
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
PhilWindle
approved these changes
Mar 31, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
BEGIN_COMMIT_OVERRIDE chore: (A-771) remove dead code, verify keypair (#22167) fix(aes128): validate PKCS#7 padding in decryptBufferCBC (#22179) chore: (A-815) fix l1 tx utils fallback id logic (#22187) fix(archiver): always advance L1-to-L2 messages syncpoint to current L1 block (#22154) chore: (A-832) fix defaultFetch double consuming response on JSON parse failure (#22194) fix: indefinite retry for prover node and agent broker communication (#22202) fix: remove unused createDispatchFn with no method allowlist (#22219) chore: fix wallet setup to use NO_FROM instead of ZERO address (#22222) fix: update aes128 bad-key test for PKCS#7 padding validation (#22190) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is purely a correctness fix, no behavioral changes as the id is only used for store operations and when there is no store, this fallback is never hit.
Fallback logic previous:
If
txs.mapis empty thenthis.txs.map(tx => tx.id)resolves to nothing andMath.max(0)resolves to 0.Next iteration,
this.txs.map(tx => tx.id)resolves to 0 andMath.max(0, 0)resolves to 0 again. Collision!Fallback logic fixed:
If
txs.mapis empty thenthis.txs.map(tx => tx.id)resolves to empty andMath.max(-1) + 1resolves to 0.Next iteration,
this.txs.map(tx => tx.id)resolves to 0 andMath.max(0, -1) + 1resolves to 1, a unique id.