fix: satisfy Chonk num_circuits >= 4 assertion in mock IVC creation#22188
Merged
iakovenkos merged 1 commit intomerge-train/barretenbergfrom Mar 31, 2026
Merged
Conversation
create_mock_chonk_from_constraints was passing constraints.size() (1-2) to Chonk constructor which now requires >= 4 after #22181. The mock doesn't use num_circuits for anything, so passing max(size, 4) is safe.
AztecBot
added
ci-draft
iakovenkos
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #22181 tightened the
Chonkconstructor to requirenum_circuits >= 4, butcreate_mock_chonk_from_constraints()was passingconstraints.size()(1-2 for most kernels), causing assertion failures during VK generation formock-protocol-circuitsandnoir-protocol-circuits.Fix
Pass
std::max(constraints.size(), 4)since the mock doesn't usenum_circuitsfor anything — it directly manipulates the verification queue.Verification
mock-protocol-circuitsbootstrap: 11/11 circuits passnoir-protocol-circuitsbootstrap: 120/120 circuits passClaudeBox log: https://claudebox.work/s/71d20ef48c81e6e3?run=1