refactor(e2e): enable pipelining in e2e_epochs tests#22544
Merged
spalladino merged 7 commits intomerge-train/spartanfrom Apr 22, 2026
Merged
refactor(e2e): enable pipelining in e2e_epochs tests#22544spalladino merged 7 commits intomerge-train/spartanfrom
spalladino merged 7 commits intomerge-train/spartanfrom
Conversation
spalladino
changed the base branch from
next
to
palla/skip-initial-sequencer-in-e2e
spalladino
force-pushed
the
palla/tests-to-pipelining
branch
from
0922fb0 to
8692be8
Compare
spalladino
added
ci-no-fail-fast
Base automatically changed from
palla/skip-initial-sequencer-in-e2e
to
merge-train/spartan
April 21, 2026 12:05
spalladino
force-pushed
the
palla/tests-to-pipelining
branch
from
c14cc38 to
858af40
Compare
Maddiaa0
approved these changes
Apr 21, 2026
spalladino
force-pushed
the
palla/tests-to-pipelining
branch
from
858af40 to
2f9926e
Compare
spalladino
force-pushed
the
palla/tests-to-pipelining
branch
from
2f9926e to
4d8f18c
Compare
spalladino
changed the base branch from
merge-train/spartan
to
spl/fix-genesis-world-state-again
Contributor
Author
|
Do not merge until the base is merged against the merge-train. I've only rebased on top of it to check if it fixed CI. |
Base automatically changed from
spl/fix-genesis-world-state-again
to
merge-train/spartan
April 22, 2026 08:43
Enable `enableProposerPipelining: true` in 13 of 19 e2e_epochs test suites. Tests with pipelining enabled: - epochs_simple_block_building, epochs_empty_blocks_proof, epochs_multiple - epochs_long_proving_time, epochs_multi_proof, epochs_proof_public_cross_chain - epochs_upload_failed_proof, epochs_ha_sync, epochs_mbps.parallel - epochs_sync_after_reorg, epochs_partial_proof, epochs_manual_rollback - epochs_invalidate_block.parallel Key changes: - Validator-based tests also need `inboxLag: 2` with pipelining - Solo-sequencer tests need ~2x timeouts for waitUntilCheckpointNumber (sequencer must wait for L1 tx to land before simulating the next) Tests where pipelining is NOT enabled (incompatible): - epochs_proof_fails, epochs_missed_l1_slot, epochs_l1_reorgs: deliberately manipulate L1 tx timing/mining - epochs_first_slot, epochs_high_tps_block_building: tight timing (3 L1 blocks per L2 slot) - epochs_mbps_redistribution: pipelining changes block building timing affecting redistribution Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ipelining With pipelining enabled, if the proposer builds blocks spanning 3+ checkpoints in a single slot, non-proposer nodes reject checkpoint N+2 blocks with CheckpointNumberNotSequentialError (checkpoint N+1 hasn't been confirmed on L1 yet). This caused the L2-to-L1 messages sub-test to fail. Fix by increasing maxTxsPerBlock so fewer blocks are built per phase, keeping each proposer within 2 checkpoints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
With MBPS (multiple blocks per slot), a single pipelining proposer can build blocks spanning 3+ checkpoints in one slot. Non-proposer nodes reject checkpoint N+2 with CheckpointNumberNotSequentialError because N+1 hasn't been confirmed on L1 yet. This is a platform limitation, not a test issue. The dedicated epochs_mbps.pipeline.parallel test already covers MBPS+pipelining with wider timing (72s slots, 12s L1 blocks) that avoids this race. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This test asserts zero sequencer errors (failEvents). Pipelining produces transient Rollup__InvalidArchive / ProposedCheckpointNotSequentialError when checkpoint N's L1 tx is slow to land while the pipelined proposer builds checkpoint N+1. These are recoverable but logged as errors, breaking the strict zero-error assertion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Delete PIPELINING_MIGRATION.md (tracked in Linear A-912 sub-issues instead) - Revert invalidation assertion to expect earliest checkpoint invalidated - Remove inline comments explaining why pipelining was not enabled Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
spalladino
force-pushed
the
palla/tests-to-pipelining
branch
from
4d8f18c to
471f1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enableProposerPipelining: truein several e2e_epochs test suitesinboxLag: 2for validator-based tests (required with pipelining)