Skip to content

fix(docs): backport #22617 — label-based API version mapping (v4-next)#22622

Merged
critesjosh merged 4 commits intobackport-to-v4-next-stagingfrom
claudebox/backport-22617-v4-next
Apr 17, 2026
Merged

fix(docs): backport #22617 — label-based API version mapping (v4-next)#22622
critesjosh merged 4 commits intobackport-to-v4-next-stagingfrom
claudebox/backport-22617-v4-next

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Backport of #22617fix(docs): restore Aztec.nr API reference links on v4.2.0 — to v4-next via backport-to-v4-next-staging.

Why the automatic cherry-pick failed

The upstream fix modifies docs/developer_versioned_docs/version-v4.2.0/docs/aztec-nr/api.mdx, which does not exist on v4-next. Git's rename detection landed the diff on version-v4.1.0-rc.2/docs/aztec-nr/api.mdx with conflict markers — the wrong target.

On v4-next, the equivalent stale useApiVersion logic lives in docs/docs-developers/docs/aztec-nr/api.mdx. That file is the source from which future versioned snapshots are cut, so without this fix the same regression would recur the moment v4.2.0 developer docs are cut from v4-next.

Commit structure

Per CLAUDE.md backport guidance:

  1. cherry-pick: ... (with conflicts) — mechanical cherry-pick committed AS-IS for history.
  2. fix: resolve cherry-pick conflicts by reverting wrong target — restores version-v4.1.0-rc.2/... (whose existing name-based logic already resolves correctly for its Testnet (v4.1.0-rc.2) label, since the name matches includes("rc")).
  3. fix(docs): use label-based API version mapping in docs-developers aztec-nr api page — applies the same 7/-5 change from fix(docs): restore Aztec.nr API reference links on v4.2.0 #22617 to the real v4-next target.

Net diff

docs/docs-developers/docs/aztec-nr/api.mdx | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

Full analysis: https://gist.github.com/AztecBot/4994eafc80a7cc7081ecf215fc4a9aec

Test plan

  • yarn start locally on v4-next, open the Aztec.nr API Reference under the Alpha version, confirm links resolve.
  • Verify the next v4.2.0 versioned cut from v4-next inherits the fixed logic.

ClaudeBox log: https://claudebox.work/s/056d3a595d4c0d37?run=1

critesjosh and others added 3 commits April 16, 2026 20:24
… aztec-nr api page (with conflicts)

Mechanical cherry-pick of 0e1c474 from PR #22617. The original fix
targets docs/developer_versioned_docs/version-v4.2.0/docs/aztec-nr/api.mdx,
which does not exist on v4-next. Git's rename detection landed the diff on
docs/developer_versioned_docs/version-v4.1.0-rc.2/docs/aztec-nr/api.mdx,
producing conflict markers. Committed AS-IS for history; next commit
reverts the wrong target and applies the fix to the right file on v4-next.
The mechanical cherry-pick in the previous commit landed conflict markers
on version-v4.1.0-rc.2/docs/aztec-nr/api.mdx (a Testnet-labelled snapshot
whose existing name-based logic correctly returns "testnet" for names
containing "rc"). Revert that file to its pre-cherry-pick state — the
v4.2.0 mainnet fix does not apply to the v4.1.0-rc.2 testnet snapshot.

The equivalent change for v4-next is applied to docs-developers in the
next commit.
…ec-nr api page

Apply the equivalent of upstream fix 0e1c474 (PR #22617) to v4-next.
On next, the fix targets the v4.2.0 versioned snapshot; on v4-next that
snapshot does not exist yet, but docs-developers/docs/aztec-nr/api.mdx
— the source that will seed the next versioned cut — still carries the
stale name-based useApiVersion logic. Replacing it with the label-based
mapping prevents the same regression recurring when v4.2.0 developer
docs are cut from v4-next.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Apr 16, 2026
@critesjosh critesjosh marked this pull request as ready for review April 17, 2026 01:22
@critesjosh critesjosh enabled auto-merge April 17, 2026 01:22
@critesjosh critesjosh merged commit 9e878ae into backport-to-v4-next-staging Apr 17, 2026
9 checks passed
@critesjosh critesjosh deleted the claudebox/backport-22617-v4-next branch April 17, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants