chore(ci): skip slow multi-block pipelining invalidate test#22707
Closed
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Closed
chore(ci): skip slow multi-block pipelining invalidate test#22707AztecBot wants to merge 1 commit intomerge-train/spartanfrom
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Conversation
Contributor
|
Failure is in a different test in that run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Run https://github.com/AztecProtocol/aztec-packages/actions/runs/24737764244 on
merge-train/spartanfailed becausee2e_epochs/epochs_invalidate_block.parallel.test.tstest caseproposer invalidates previous checkpoint with multiple blocks while posting its ownexhausted its 600 s per-test docker budget on both the initial attempt and the test_engine retry. The other 7 sibling tests in the same file passed.The failing test was added in #22586 and is the only one in the file that combines pipelining, multi-block checkpoints, mid-test attestation toggling, and an extra
waitUntilNextL2Slot()step before asserting the invalidation+propose are bundled in the same L1 tx — significantly longer end-to-end than the sibling tests.The sequencer-side implementation in
checkpoint_proposal_job.tsmatches what the test expects (pre-enqueued invalidation + post-buildenqueueCheckpointForSubmissionproduces the bundled tx); the issue is purely that the scenario doesn't fit in 10 minutes under merge-train runner load.Fix
Skip this specific test in
.test_patterns.yml, mirroring the existing entry forepochs_mbps.pipeline.parallel.test.ts.*prunes uncheckpointed(also a slow pipelining scenario). Owner @spalladino so they can re-enable after tightening the test or bumping the per-test timeout.Full analysis: https://gist.github.com/AztecBot/9823ef5385a8aa3843ad0fce81cf1c54
ClaudeBox log: https://claudebox.work/s/6cf0a1294e91c8b4?run=1