fix(e2e): wait for first checkpoint in fee_asset_price_oracle_gossip test#22719
Merged
alexghr merged 1 commit intomerge-train/spartanfrom Apr 22, 2026
Merged
fix(e2e): wait for first checkpoint in fee_asset_price_oracle_gossip test#22719alexghr merged 1 commit intomerge-train/spartanfrom
alexghr merged 1 commit intomerge-train/spartanfrom
Conversation
Maddiaa0
approved these changes
Apr 22, 2026
…test setupAccount() no longer sends a tx, so targetBlock was 0 and the existing retryUntil was trivially satisfied before any checkpoint had been published. The test then queried the archiver for checkpoints, got an empty array, and crashed dereferencing publishedCheckpoint.checkpoint. Wait for the archiver to index the first published checkpoint before reading attestations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e_p2p/fee_asset_price_oracle_gossip.test.tswas failing withTypeError: Cannot read properties of undefined (reading 'checkpoint').setupAccount()no longer sends an L2 tx (it just registers a hardcoded account in PXE), sotargetBlock = aztecNode.getBlockNumber()is0and the existingretryUntilis trivially satisfied. The test then queriesdataStore.getCheckpoints(...)before any checkpoint has been published/indexed, gets[]back, and crashes on destructure.getCheckpointscall in aretryUntil(120s timeout, ample for a ~48s checkpoint cadence atslotDuration=24× 2 blocks) that waits until the archiver has indexed the first published checkpoint. QueryCheckpointNumber(0)directly —fromBlockNumberis deprecated and any published checkpoint is sufficient to validate the attestation signers.Failure: https://ci.aztec-labs.com/logs/acab993c3a6c25c5
Test plan
e2e_p2p/fee_asset_price_oracle_gossip.test.tspasses🤖 Generated with Claude Code