fix(ci): Unify noir contract compilation error snapshot testing

[vezenovm]

Resolves https://linear.app/aztec-labs/issue/F-577/unified-noir-contract-error-snapshot-testing

Summary:

• 4 cases moved into noir-projects/noir-contracts-comp-failures/contracts/
• Old runner deleted: noir-projects/aztec-nr/macro_compilation_failure_tests/ + both invocations in noir-projects/aztec-nr/bootstrap.sh.
• Runner extended (noir-projects/noir-contracts-comp-failures/bootstrap.sh):
  • Matcher asserts strict equality, line-for-line, between the error: headlines nargo emits (prefix stripped, in emission order) and the non-blank lines of expected_error. Any difference in text, count, or order fails the test.
  • ACCEPT_SNAPSHOTS=1 ./bootstrap.sh test auto-extracts every error: headline and writes them one-per-line into expected_error. A ⚠ fallback writes full stderr when nargo emits no error: lines (ICE/panic), prompting a manual edit.
    • Devs no longer have to write their own expected_error file manually
  • CI guard: ACCEPT_SNAPSHOTS=1 + CI=1 is refused, so committed snapshots and live stderr can only diverge when a dev regenerates locally and commits.
  • test accepts an optional contract-name glob to run a subset: ./bootstrap.sh test reserved_public_dispatch or ./bootstrap.sh test 'panic_on_*'. No-arg behaviour is unchanged; test_cmds (CI wiring) still emits the no-arg form. Composes with ACCEPT_SNAPSHOTS=1 for targeted snapshot updates.
• Snapshots regenerated (13 expected_error files changed):
  • Added specificity where previous dropped by manual trims (e.g. duplicate_storage now pins 'Storage', got 'Storage2' instead., event_selector_collision pins both colliding event names, marked_*_unconstrained pins the function name).
  • Several cases gained cascading downstream error: lines that previous single-line trims were hiding (Could not resolve 'init'/'ZERO' in path, Type annotation needed). Kept them in the snapshot. This is part of the actual compiler behavior being asserted.
• READMEs updated: aztec-nr README; comp-failures README

Verification (done manually):

cd noir-projects/noir-contracts-comp-failures

1. Happy case:

./bootstrap.sh test

2. Wrong-error path:
   I replaced the message in contracts/reserved_public_dispatch/expected_error with garbage

./bootstrap.sh test

Gives this output:
...
✓ contracts/panic_on_owned_state_var_in_storage/: Compilation failed as expected with correct error(s)
✓ contracts/public_function_selector_collision/: Compilation failed as expected with correct error(s)
✓ contracts/reserved_emit_public_init_nullifier/: Compilation failed as expected with correct error(s)
✗ contracts/reserved_public_dispatch/: error 1 does not match
  Expected: Function name '' is reserved for internal use
  Actual:   Function name 'public_dispatch' is reserved for internal use

4. Success-compile path:
   Change reserved_public_dispatch to contract ReservedPublicDispatch {} so that it succeeds compilation.

...
✓ contracts/public_function_selector_collision/: Compilation failed as expected with correct error
✓ contracts/reserved_emit_public_init_nullifier/: Compilation failed as expected with correct error
✗ contracts/reserved_public_dispatch/: Expected compilation to fail but it succeeded

5. Missing error
   Removed "Could not resolve 'init' in path" from panic_on_owned_state_var_in_storage. Running bootstrap we get the following:

✗ contracts/panic_on_owned_state_var_in_storage/: error count mismatch — expected 2, got 3
Expected lines:
  Type PrivateImmutable<Field, Context> implements OwnedStateVariable and hence cannot be placed in Storage struct without being wrapped in Owned. Define the type in storage as Owned<PrivateImmutable<Field, Context><..., Context>>, Context>.
  Type annotation needed
Actual error headlines:
  Type PrivateImmutable<Field, Context> implements OwnedStateVariable and hence cannot be placed in Storage struct without being wrapped in Owned. Define the type in storage as Owned<PrivateImmutable<Field, Context><..., Context>>, Context>.
  Could not resolve 'init' in path
  Type annotation needed
Full stderr:
error: Type PrivateImmutable<Field, Context> implements OwnedStateVariable and hence cannot be placed in Storage struct without being wrapped in Owned. Define the type in storage as Owned<PrivateImmutable<Field, Context><..., Context>>, Context>.
  ┌─ std/panic.nr:8:12
  │
8 │     assert(false, message);
  │            ----- Assertion failed
  │
  = Call stack:
    1: PanicOnOwnedStateVarInStorage::#[storage]
            at src/main.nr:8:5
    2: storage

<omitted full call stack here>
Aborting due to 3 previous errors

Bringing back the error bootstrap will succeed again.

6. Extra error

✗ contracts/panic_on_owned_state_var_in_storage/: error count mismatch — expected 4, got 3
Expected lines:
  Type PrivateImmutable<Field, Context> implements OwnedStateVariable and hence cannot be placed in Storage struct without being wrapped in Owned. Define the type in storage as Owned<PrivateImmutable<Field, Context><..., Context>>, Context>.
  Could not resolve 'init' in path
  Type annotation needed
  Type annotation needed
Actual error headlines:
  Type PrivateImmutable<Field, Context> implements OwnedStateVariable and hence cannot be placed in Storage struct without being wrapped in Owned. Define the type in storage as Owned<PrivateImmutable<Field, Context><..., Context>>, Context>.
  Could not resolve 'init' in path
  Type annotation needed
Full stderr:
error: Type PrivateImmutable<Field, Context> implements OwnedStateVariable and hence cannot be placed in Storage struct without being wrapped in Owned. Define the type in storage as Owned<PrivateImmutable<Field, Context><..., Context>>, Context>.
  ┌─ std/panic.nr:8:12
  │
8 │     assert(false, message);
  │            ----- Assertion failed
  │
  = Call stack:

<omitted full call stack here>
Aborting due to 3 previous errors

7. Valid number of errors but wrong error

I swapped the two errors in panic_on_owned_state_var_in_storage, where we got:

✗ contracts/panic_on_owned_state_var_in_storage/: error 2 does not match
  Expected: Type annotation needed
  Actual:   Could not resolve 'init' in path

8. ACCEPT_SNAPSHOTS path:
   Remove the function names from contracts/reserved_public_dispatch/expected_error and contracts/reserved_emit_public_init_nullifier/expected_error (e.g., Function name '' is reserved for internal use).

ACCEPT_SNAPSHOTS=1 ./bootstrap.sh test

Afterwards the expected_error for both tests will contain the appropriate error with the name (e.g., Function name 'public_dispatch' is reserved for internal use).

All the invariants of running the script above resulted as expected.

[nchamo]

LGTM

[AztecBot]

✅ Successfully backported to backport-to-v4-next-staging #22763.