refactor(stdlib): consolidate find-function-by-selector helpers#23008
Open
dbanks12 wants to merge 1 commit intodb/fastforward-contract-updatefrom
Open
refactor(stdlib): consolidate find-function-by-selector helpers#23008dbanks12 wants to merge 1 commit intodb/fastforward-contract-updatefrom
dbanks12 wants to merge 1 commit intodb/fastforward-contract-updatefrom
Conversation
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
2 times, most recently
from
ee7d882 to
fca916d
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
4620c69 to
544c520
Compare
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
fca916d to
0b5052d
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
544c520 to
bd45d90
Compare
This was referenced May 7, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
bd45d90 to
761b425
Compare
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
0b5052d to
50fe709
Compare
dbanks12
changed the base branch from
db/private-sim-contract-overrides
to
graphite-base/23008
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
761b425 to
dc6a7b5
Compare
dbanks12
force-pushed
the
graphite-base/23008
branch
from
50fe709 to
cf63e74
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
dc6a7b5 to
ee3005d
Compare
dbanks12
force-pushed
the
graphite-base/23008
branch
from
cf63e74 to
721ca99
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
ee3005d to
52a8355
Compare
dbanks12
changed the base branch from
graphite-base/23008
to
db/fastforward-contract-update
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
52a8355 to
875d840
Compare
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
from
721ca99 to
7b2bf7e
Compare
2 tasks
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
from
7b2bf7e to
f752939
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
2 times, most recently
from
952c942 to
9ea80fe
Compare
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
from
f752939 to
5eab42b
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
9ea80fe to
d93eec1
Compare
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
from
5eab42b to
bad11ee
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
d93eec1 to
7cdc4d6
Compare
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
2 times, most recently
from
6ee0009 to
bc31ce0
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
2 times, most recently
from
61dc935 to
48179ec
Compare
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
2 times, most recently
from
1f320fd to
c05adb8
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
48179ec to
7f6ff8d
Compare
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
from
c05adb8 to
e7a14dc
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
7f6ff8d to
9204319
Compare
The same artifact lookup loop was duplicated three times — as ContractStore's private #findFunctionArtifactBySelector and #findFunctionAbiBySelector, and as a local helper inside ProxiedContractStoreFactory. Hoist the two variants into stdlib/abi as findFunctionArtifactBySelector and findFunctionAbiBySelector so both ContractStore and the proxied store call the same primitive. Also have the existing throwing getFunctionArtifact helper reuse findFunctionArtifactBySelector for its selector branch.
dbanks12
force-pushed
the
db/fastforward-contract-update
branch
from
e7a14dc to
aef8c87
Compare
dbanks12
force-pushed
the
db/consolidate-find-fn-helpers
branch
from
9204319 to
191de66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses comment #22957 (comment)
The same artifact-lookup loop was duplicated three times. Puts two helper fns in
stdlib/abi:findFunctionArtifactBySelector(artifact, selector)— searchesartifact.functions, returnsFunctionArtifact | undefined.findFunctionAbiBySelector(artifact, selector)— searchesartifact.functions ∪ nonDispatchPublicFunctionsviagetAllFunctionAbis, returnsFunctionAbi | undefined.Both
ContractStoreandProxiedContractStoreFactorynow call the same stdlib primitive. The existing throwinggetFunctionArtifacthelper also reusesfindFunctionArtifactBySelector.Test plan
yarn workspace @aztec/pxe test src/storage/contract_store/contract_store.test.tsyarn workspace @aztec/stdlib test src/abi/abi.test.tsyarn lint pxe,yarn lint stdlib