Skip to content

Conversation

@imnaseer
Copy link
Member

Purpose

  • Update workbench to 1.7.3

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: Security fixes

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@imnaseer imnaseer requested review from ali92hm and brendalee August 27, 2019 22:39

Set-Item Env:\SuppressAzurePowerShellBreakingChangeWarnings "true"
# Comment the next line in before publishing
# Set-Item Env:\SuppressAzurePowerShellBreakingChangeWarnings "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment this in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commented - do you want me to remove the comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line bellow the comment should be in Set-Item Env:\SuppressAzurePowerShellBreakingChangeWarnings "true"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at the latest changes here?

Copy link
Contributor

@ali92hm ali92hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brendalee brendalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks!

@imnaseer imnaseer merged commit d5f77e6 into Azure-Samples:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants