refresh token fix for DelegatedTokenCredentials & UserTokenCredentials#632
Merged
jianghaolu merged 2 commits intoAzure:masterfrom Sep 12, 2019
Merged
refresh token fix for DelegatedTokenCredentials & UserTokenCredentials#632jianghaolu merged 2 commits intoAzure:masterfrom
jianghaolu merged 2 commits intoAzure:masterfrom
Conversation
- current implementation is using RefreshTokenClient for refresh token but RefreshTokenClient doesnt use client_secret - changed to using AuthenticationContext as in acquireNewAccessToken bug flow: - get authorization_code - initialize DelegatedTokenCredentials with authorization_code - do request to resource A with DelegatedTokenCredentials (OK) - do request to resource B with DelegatedTokenCredentials (fail with message OAuth2 Authorization code was already redeemed) But actually bug is not about authorization_code. First exception occurs in RefreshTokenClient in method refreshToken but he just returns null in catch block and by this reason DelegatedTokenCredentials is trying to use authorization_code to acquire access token
jianghaolu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ViktorFefilov
resolves #625