[Containerapp] az containerapp env http-route-config/premium-ingress: Remove GA commands which exist in azure-cli version 2.79.0#9265
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env http-route-config create | cmd containerapp env http-route-config create removed property is_preview |
||
| containerapp env http-route-config delete | cmd containerapp env http-route-config delete removed property is_preview |
||
| containerapp env http-route-config list | cmd containerapp env http-route-config list removed property is_preview |
||
| containerapp env http-route-config show | cmd containerapp env http-route-config show removed property is_preview |
||
| containerapp env http-route-config update | cmd containerapp env http-route-config update removed property is_preview |
||
| containerapp env premium-ingress add | cmd containerapp env premium-ingress add added parameter max_replicas |
||
| containerapp env premium-ingress add | cmd containerapp env premium-ingress add added parameter min_replicas |
||
| containerapp env premium-ingress add | cmd containerapp env premium-ingress add removed property is_preview |
||
| containerapp env premium-ingress remove | cmd containerapp env premium-ingress remove removed property is_preview |
||
| containerapp env premium-ingress show | cmd containerapp env premium-ingress show removed property is_preview |
||
| containerapp env premium-ingress update | cmd containerapp env premium-ingress update added parameter max_replicas |
||
| containerapp env premium-ingress update | cmd containerapp env premium-ingress update added parameter min_replicas |
||
| containerapp env premium-ingress update | cmd containerapp env premium-ingress update removed property is_preview |
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Tratcher Release SuggestionsModule: containerapp
Notes
|
Tratcher
changed the title
| g.custom_command('delete', 'delete_managed_environment', supports_no_wait=True, confirmation=True, exception_handler=ex_handler_factory()) | ||
| g.custom_command('update', 'update_managed_environment', supports_no_wait=True, exception_handler=ex_handler_factory()) | ||
|
|
||
| with self.command_group('containerapp env http-route-config', is_preview=True) as g: |
There was a problem hiding this comment.
To avoid breaking change, we can remove the is_preview=True in extension first.
Then after azure-cli release, we update "azext.minCliCoreVersion": <azure-cli-version> in azext_metadata.json first, then remove these GA commands in extension.
There was a problem hiding this comment.
what if we just wait to merge this until after the azure-cli release?
There was a problem hiding this comment.
@Tratcher It depends on if you mind customer will see the Preview tag if they already install latest containerapp extension and azure-cli version.
If you care the Preview Tag, it should separate to 2 PR.
There was a problem hiding this comment.
But yes we can just wait to merge until after the azure-cli release.
Besides I will discuss the azure-cli-extension containerapp module release plan for ignite with co-workers after holiday to double check if we have plan to release a new version to separate these.
|
CLI 2.79.0 has shipped, this can merge now. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated preview features and fixes a typo in a test utility function name. The main changes include:
- Correcting the function name from
create_vent_subnettocreate_vnet_subnet(fixing a typo) - Removing the HTTP route config feature (commands, implementation, parameters, and help text)
- Removing the premium ingress feature (commands, implementation, parameters, and help text)
- Deleting a test file that tested the removed HTTP route config feature
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/containerapp/azext_containerapp/tests/latest/utils.py | Fixed typo in function name from create_vent_subnet to create_vnet_subnet and updated all call sites |
| src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py | Updated imports and function calls to use corrected create_vnet_subnet name |
| src/containerapp/azext_containerapp/tests/latest/test_containerapp_mount_secret_volume.py | Updated imports and function calls to use corrected create_vnet_subnet name |
| src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_http_route_config.py | Removed entire test file for deprecated HTTP route config feature |
| src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py | Updated imports and function calls to use corrected create_vnet_subnet name |
| src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py | Removed test for deprecated premium ingress feature |
| src/containerapp/azext_containerapp/custom.py | Removed HTTP route config and premium ingress command implementations and removed unused import |
| src/containerapp/azext_containerapp/commands.py | Removed command definitions for HTTP route config and premium ingress features |
| src/containerapp/azext_containerapp/_params.py | Removed parameter definitions for HTTP route config and premium ingress commands |
| src/containerapp/azext_containerapp/_help.py | Removed help documentation for HTTP route config and premium ingress commands |
Comments suppressed due to low confidence (1)
src/containerapp/azext_containerapp/custom.py:1
- The
HttpRouteConfigPreviewClientimport is being removed fromcustom.py, but the client class definition still exists in_clients.py(lines 458-543). Since this client is no longer used anywhere in the codebase after removing the HTTP route config commands, consider also removing theHttpRouteConfigPreviewClientclass definition from_clients.pyto avoid maintaining dead code.
# --------------------------------------------------------------------------------------------
Updated the HISTORY.rst to reflect changes in CLI commands and dependencies.
Greedygre
changed the title
az containerapp env http-route-config/premium-ingress: Remove GA commands which exist in azure-cli version 2.79.0
These features are moving to the core CLI and no longer need to be overridden in the extension.
Greedygre/azure-cli#4
Also fixed a typo in the name of
create_vnet_subnetso it is the same in both repos.