Skip to content

[AKS] update control-plane-only user confirmation prompt#9404

Merged
yanzhudd merged 7 commits intoAzure:mainfrom
m-chau:control-plane-only-prompt-update
Dec 5, 2025
Merged

[AKS] update control-plane-only user confirmation prompt#9404
yanzhudd merged 7 commits intoAzure:mainfrom
m-chau:control-plane-only-prompt-update

Conversation

@m-chau
Copy link
Copy Markdown
Contributor

@m-chau m-chau commented Nov 7, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks upgrade

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@m-chau m-chau requested a review from andyliuliming as a code owner November 7, 2025 23:43
Copilot AI review requested due to automatic review settings November 7, 2025 23:43
@m-chau m-chau requested a review from FumingZhang as a code owner November 7, 2025 23:43
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @m-chau,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 7, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 7, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 7, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the clarity of the warning message displayed during control-plane-only AKS upgrades by providing more detailed information about what will and won't be upgraded.

  • Enhanced the user-facing message to explicitly clarify that only the Kubernetes version of the control plane is upgraded
  • Added important information about node pool behavior: Kubernetes versions remain unchanged, but node image versions may still be upgraded if cluster config changes require VM reimage

@FumingZhang
Copy link
Copy Markdown
Member

please resolve merge conflict and fix failed CI checks

@FumingZhang
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 11, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 11, 2025

Please fix CI issues

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Dec 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@FumingZhang
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit d87a3e7 into Azure:main Dec 5, 2025
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Dec 5, 2025

[Release] Update index.json for extension [ aks-preview-19.0.0b17 ] : https://dev.azure.com/msazure/One/_build/results?buildId=145675157&view=results

DhritiJindal27 pushed a commit to DhritiJindal27/azure-cli-extensions that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants