[Internal] DTS: Adds retries in DTS when isRetriable is true and on timeout#5689
Draft
Meghana-Palaparthi wants to merge 1 commit intomasterfrom
Draft
[Internal] DTS: Adds retries in DTS when isRetriable is true and on timeout#5689Meghana-Palaparthi wants to merge 1 commit intomasterfrom
Meghana-Palaparthi wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces robust retry logic for distributed transaction commits and improves the handling and parsing of distributed transaction responses in the Cosmos DB SDK. The changes ensure that commit operations are retried safely in the event of timeouts or retriable errors, enhance diagnostics, and make response parsing more resilient. Additionally, the request and response classes are refactored for safer stream handling and improved reliability.
Distributed transaction commit improvements:
DistributedTransactionCommitterResponse parsing and diagnostics enhancements:
isRetriableandserverDiagnosticsfields, and improved resilience to partial JSON parsing failures.IsRetriableproperty toDistributedTransactionResponseand ensured it is correctly populated from server responses.Request stream handling improvements:
DistributedTransactionServerRequestto use a pre-serialized byte array for the request body, enabling safe creation of new memory streams for each retry and preventing disposal issues.Reliability and correctness fixes:
DistributedTransactionResponse.DistributedTransactionOperationResultto throw explicit exceptions on failure.Miscellaneous:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber