fixing dotnet-version updates during publish#2639
Merged
Conversation
brettsam
commented
Jul 8, 2021
| } | ||
|
|
||
| string normalizedVersion = $"{parsedVersion.Major}.{parsedVersion.Minor}"; | ||
| ColoredConsole.WriteLine($"Using dotnet-version value of '{normalizedVersion}'."); |
Member
Author
There was a problem hiding this comment.
Decided there wasn't really a need to write this out during parsing as it can be noisy; we'll still log if we change it.
ankitkumarr
approved these changes
Jul 9, 2021
brettsam
commented
Jul 10, 2021
| public Action<string> PreTest { get; set; } | ||
| public Func<string, Process, Task> Test { get; set; } | ||
| public TimeSpan CommandTimeout { get; set; } = TimeSpan.FromSeconds(20); | ||
| public TimeSpan CommandTimeout { get; set; } = TimeSpan.FromSeconds(40); |
Member
Author
There was a problem hiding this comment.
bumping this up -- some e2e tests were timing out.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues related to dotnet-isolated publishing:
dotnet-versiontwice.dotnet-versionwasn't specified, it was rolling back to 5.0./cc @anthonychu that ran into this