Skip to content

Update PowerShell worker runtime filters #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liliankasem merged 1 commit into from
Apr 28, 2025
Merged

Update PowerShell worker runtime filters #4389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions build/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,18 @@ private static string config(string @default = null, [CallerMemberName] string k
{
"linux",
"linux-x64",
"linux-arm64",
"unix",
"linux-musl-x64"
};

private static readonly string[] _linARMPowershellRuntimes = new[]
{
"linux",
"linux-arm",
"linux-arm64",
"unix"
};

private static readonly string[] _osxPowershellRuntimes = new[]
{
"osx",
Expand All @@ -120,7 +127,7 @@ private static Dictionary<string, string[]> GetPowerShell72Runtimes()
{ "win-x64", _winPowershellRuntimes },
{ "win-arm64", _winPowershellRuntimes },
{ "linux-x64", _linPowershellRuntimes },
{ "linux-arm64", _linPowershellRuntimes },
{ "linux-arm64", _linARMPowershellRuntimes },
{ "osx-x64", _osxPowershellRuntimes },
{ "osx-arm64", _osxARMPowershellRuntimes }
};
Expand All @@ -135,7 +142,7 @@ private static Dictionary<string, string[]> GetPowerShell74Runtimes()
{ "win-x64", _winPowershellRuntimesNet8 },
{ "win-arm64", _winPowershellRuntimesNet8 },
{ "linux-x64", _linPowershellRuntimes },
{ "linux-arm64", _linPowershellRuntimes },
{ "linux-arm64", _linARMPowershellRuntimes },
{ "osx-x64", _osxPowershellRuntimes },
{ "osx-arm64", _osxARMPowershellRuntimes }
};
Expand All @@ -153,12 +160,12 @@ private static Dictionary<string, string[]> GetPowerShell74Runtimes()
{ "win-x64", _winPowershellRuntimes },
{ "win-arm64", _winPowershellRuntimes },
{ "linux-x64", _linPowershellRuntimes },
{ "linux-arm64", _linPowershellRuntimes },
{ "osx-x64", _osxPowershellRuntimes },
// NOTE: PowerShell 7.0 does not support arm. First version supporting it is 7.2
// https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-macos?view=powershell-7.2#supported-versions
// That being said, we might as well include "osx" and "unix" since it'll hardly affect package size and should lead to more accurate error messages
{ "osx-arm64", new [] { "osx", "unix" } }
{ "osx-arm64", new [] { "osx", "unix" } },
{ "linux-arm64", new [] { "linux", "unix" } }
}
},
{
Expand Down