Add EOL warnings for all runtimes during function app publish#4760
Merged
liliankasem merged 2 commits intomainfrom Jan 7, 2026
Merged
Add EOL warnings for all runtimes during function app publish#4760liliankasem merged 2 commits intomainfrom
liliankasem merged 2 commits intomainfrom
Conversation
5 tasks
satvu
approved these changes
Jan 7, 2026
aishwaryabh
reviewed
Jan 7, 2026
| if (isAlreadyEol || currentRuntimeSettings.IsDeprecated == true || currentRuntimeSettings.IsDeprecatedForRuntime == true) | ||
| { | ||
| var warningMessage = EolMessages.GetAfterEolCreateMessageDotNet(majorDotnetVersion.ToString(), currentRuntimeSettings.EndOfLifeDate.Value); | ||
| var warningMessage = EolMessages.GetAfterEolCreateMessage(".NET", majorDotnetVersion.ToString(), currentRuntimeSettings.EndOfLifeDate.Value); |
Contributor
There was a problem hiding this comment.
nit: ".NET" can be a const
aishwaryabh
reviewed
Jan 7, 2026
|
|
||
| // Get version from Function App configuration (not local project) | ||
| if (runtime == WorkerRuntime.DotnetIsolated || runtime == WorkerRuntime.Dotnet) | ||
| { |
Contributor
There was a problem hiding this comment.
can we have this be a helper method for .NET? It's a bit heavy with the nested if statements
aishwaryabh
reviewed
Jan 7, 2026
| int? dotnetMajorVersion = null; | ||
|
|
||
| // Get version from Function App configuration (not local project) | ||
| if (runtime == WorkerRuntime.DotnetIsolated || runtime == WorkerRuntime.Dotnet) |
Contributor
There was a problem hiding this comment.
can we have this check as a variable that we establish above so we don't repeat the same check?
aishwaryabh
reviewed
Jan 7, 2026
| ColoredConsole.WriteLine(WarningColor(message)); | ||
| } | ||
|
|
||
| private class EolInformation |
Contributor
There was a problem hiding this comment.
can we have this be in its own file? this file has a bunch of content already so would be good to seperate it out!
aishwaryabh
approved these changes
Jan 7, 2026
4 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #4241
Pull request checklist
release_notes.mdAdditional information
Implements end-of-life (EOL) warnings for all runtime versions during
func azure functionapp publish.Temporarily modified EOL threshold to 12m to validate with other languages: