Add worker indexing message types to protobuf#56
Conversation
Added messages to handle worker indexing pipeline WorkerFunctionMetadata includes all information necessary to populate FunctionMetadata and convey the indexing status for each function (ie. success, failure, etc.). Each of these messages corresponds to a single function. WorkerFunctionMetadataRequest sends the function app directory to the worker. WorkerFunctionMetadataResponse includes a list of WorkerFunctionMetadata messages and an overall StatusResult attribute.
pragnagopa
left a comment
pragnagopa
left a comment
There was a problem hiding this comment.
Added few comments - mostly around re-using existing messages
Removed WorkerFunctionMetadata message type and added some necessary fields to RpcFunctionMetadata Renamed request and response messages to be more bi-directional friendly
pragnagopa
left a comment
pragnagopa
left a comment
There was a problem hiding this comment.
Changes look good! Please update PR description to reflect incorporated PR feedback
Rename directory variable for consistency and clarity
|
Have you considered how host can handle reloading of functions by the worker ? i.e. python worker can reload functions without restarting the process on file changes --> then when worker is re-indexes the functions --> it should send FunctionsLoadResponses again --> this means I would like understand a bit more on the requirement for Host to send first message asking to load functions --- this might not be needed? |
|
@pragnagopa I think this requires more discussion, I'll set up a time to meet. |
2 participants
FunctionsMetadataRequestFunctionMetadataResponses