Merged
Conversation
gavin-aguiar
reviewed
May 2, 2025
hallvictoria
commented
May 6, 2025
hallvictoria
commented
May 6, 2025
hallvictoria
commented
May 6, 2025
| inputs: | ||
| contents: | | ||
| ${{ parameters.workerPath }} | ||
| contents: '$(workerPath)' |
Contributor
Author
There was a problem hiding this comment.
workerPath is set above. For Python 3.12 & under, the path is python/prodV4/worker.py. For 3.13+, it is python/proxyV4/worker.py
hallvictoria
commented
May 6, 2025
hallvictoria
commented
May 6, 2025
| matrix: | ||
| Python37V4: | ||
| pythonVersion: '3.7' | ||
| workerPath: 'python/prodV4/worker.py' |
Contributor
Author
There was a problem hiding this comment.
One of the comments from the 3.13 PR was to make workerPath a top-level variable. Since workerPath is different based on 3.13+ and <3.13, it can't be a global variable. The solution was to instead define 2 new global variables: one for the prodv4 path, and one for the proxyv4 path. Then, in the env_gen files, we determine which path to use based on the python version.
hallvictoria
commented
May 6, 2025
hallvictoria
commented
May 6, 2025
hallvictoria
commented
May 6, 2025
hallvictoria
commented
May 6, 2025
tests/extension_tests/deferred_bindings_tests/test_deferred_bindings_blob_functions.py
Show resolved
Hide resolved
gavin-aguiar
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
linux-arm64builds.Note:
win-arm64is not supported because GRPC does not have awin-arm64build.Testing fixes:
skipTestvariable settingPipeline refactoring:
pack/intoeng/workerPathinto top-level variablesBuild fixes:
OSX_ARM64build intoOSX/ARM64folderFixes #1643
PR information
Quality of Code and Contribution Guidelines