Skip to content

Az.DataFactory update to include Global Parameters#12290

Merged
VeryEarly merged 6 commits intoAzure:masterfrom
Ceespino:master
Jul 3, 2020
Merged

Az.DataFactory update to include Global Parameters#12290
VeryEarly merged 6 commits intoAzure:masterfrom
Ceespino:master

Conversation

@Ceespino
Copy link
Copy Markdown
Contributor

@Ceespino Ceespino commented Jun 30, 2020

Description

Added global parameters to Data Factory

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • [] For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@VeryEarly VeryEarly self-assigned this Jun 30, 2020
Copy link
Copy Markdown
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you help me understand where this "global parameters" comes from?

  • If it's needed, it should be called "GlobalParameter"

  • Please update and check in Set-AzDataFactoryV2.md only

@Ceespino
Copy link
Copy Markdown
Contributor Author

Ceespino commented Jun 30, 2020

  • Can you help me understand where this "global parameters" comes from?
  • If it's needed, it should be called "GlobalParameter"
  • Please update and check in Set-AzDataFactoryV2.md only

Global Parameters is a new property in the Data Factory entity. It is basically a dictionary that contains global constants that can be referenced and used by its subresources.

I think it should be called "Global Parameters" since that's the name that it is refered to in the SDK, factory entity and in our UI where our customers can author and use them.

Ran the tool again to only update the Get and Set AzDataFactoryV2 cmdlet since those are the ones affected.

@Ceespino Ceespino changed the title Updated Data Factory module to handle Global Parameters Updated Data Factory module to include Global Parameters Jun 30, 2020
@Ceespino
Copy link
Copy Markdown
Contributor Author

@shawnxzq to review the changes and visibility.

@Ceespino Ceespino changed the title Updated Data Factory module to include Global Parameters Az.DataFactory update to include Global Parameters Jun 30, 2020
@VeryEarly
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Copy Markdown
Collaborator

  • Can you help me understand where this "global parameters" comes from?
  • If it's needed, it should be called "GlobalParameter"
  • Please update and check in Set-AzDataFactoryV2.md only

Global Parameters is a new property in the Data Factory entity. It is basically a dictionary that contains global constants that can be referenced and used by its subresources.

I think it should be called "Global Parameters" since that's the name that it is refered to in the SDK, factory entity and in our UI where our customers can author and use them.

Ran the tool again to only update the Get and Set AzDataFactoryV2 cmdlet since those are the ones affected.

Please follow powershell convention and use singularity for parameter names
https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/design-guidelines/parameter-best-practices.md

@Ceespino
Copy link
Copy Markdown
Contributor Author

Ceespino commented Jul 2, 2020

  • Can you help me understand where this "global parameters" comes from?
  • If it's needed, it should be called "GlobalParameter"
  • Please update and check in Set-AzDataFactoryV2.md only

Global Parameters is a new property in the Data Factory entity. It is basically a dictionary that contains global constants that can be referenced and used by its subresources.
I think it should be called "Global Parameters" since that's the name that it is refered to in the SDK, factory entity and in our UI where our customers can author and use them.
Ran the tool again to only update the Get and Set AzDataFactoryV2 cmdlet since those are the ones affected.

Please follow powershell convention and use singularity for parameter names
https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/design-guidelines/parameter-best-practices.md

Updated name to GlobalParameterDefinition

@Ceespino
Copy link
Copy Markdown
Contributor Author

Ceespino commented Jul 2, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Commenter does not have sufficient privileges for PR 12290 in repo Azure/azure-powershell

@Ceespino
Copy link
Copy Markdown
Contributor Author

Ceespino commented Jul 3, 2020

@VeryEarly Can we include this in the next release please? (7/14)

@VeryEarly
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit f16ce88 into Azure:master Jul 3, 2020
@VeryEarly
Copy link
Copy Markdown
Collaborator

yes we can, merged.

@shawnxzq
Copy link
Copy Markdown
Member

shawnxzq commented Jul 3, 2020

Looks good to me, thanks @Ceespino

litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
* Added global parameters to Data Factory

* Updated ADF changelog

* Updated Doc

* Revert "Updated Doc"

This reverts commit a7fc37f.

* Updated cmdlets doc and bug fix

* Updated global parameters parameter name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants