[PS] Migrate ManagedServices module to autorest v4

src/ManagedServices/ManagedServices.Autorest/Properties/AssemblyInfo.cs

@@ -20,7 +20,7 @@
 [assembly: System.Reflection.AssemblyCopyrightAttribute("Copyright © Microsoft")]
 [assembly: System.Reflection.AssemblyProductAttribute("Microsoft Azure PowerShell")]
 [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - ManagedServices")]
-[assembly: System.Reflection.AssemblyFileVersionAttribute("3.1.2")]
-[assembly: System.Reflection.AssemblyVersionAttribute("3.1.2")]
+[assembly: System.Reflection.AssemblyFileVersionAttribute("3.1.3")]
+[assembly: System.Reflection.AssemblyVersionAttribute("3.1.3")]
 [assembly: System.Runtime.InteropServices.ComVisibleAttribute(false)]
 [assembly: System.CLSCompliantAttribute(false)]

src/ManagedServices/ManagedServices.Autorest/README.md

@@ -38,14 +38,6 @@ title: ManagedServices
 module-version: 2.0.0
 subject-prefix: $(service-name)
 
-identity-correction-for-post: true
-resourcegroup-append: true
-nested-object-to-string: true
-
-# For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option
-use-extension:
-  "@autorest/powershell": "3.x"
-
 directive:
   - where:
       verb: New|Get
@@ -139,8 +131,7 @@ directive:
 
   # Remove variant of the cmdlet
   - where:
-      verb: New
-      variant: ^Create$|^CreateViaIdentity$|^CreateViaIdentityExpanded$
+      variant: ^(Create|Update)(?!.*?(Expanded|JsonFilePath|JsonString))|^CreateViaIdentityExpanded$
     remove: true
 
   # Hide cmdlet
@@ -162,18 +153,12 @@ directive:
       default:
         script: '"subscriptions/" + (Get-AzContext).Subscription.Id'
 
-  # The regex(^/(?<scope>[^/]+)/) mathch failed because the scope inlcude '/' character.
-  # Replace regex to fixed it. 
-  - from: source-file-csharp
-    where: $
-    transform: $ = $.replace(/global::System.Text.RegularExpressions.Regex\(\"\^\/\(\?\<scope\>\[\^\/\]\+\)/g, 'global::System.Text.RegularExpressions.Regex("^/(?<scope>.+)');
-
   # Generate memory object as parameter of the cmelet.
   - model-cmdlet:
-    # - Authorization
-    - EligibleApprover
+    - model-name: Authorization
+    - model-name: EligibleApprover
     # Need custom that add ArgumentCompleterAttribute for JustInTimeAccessPolicyMultiFactorAuthProvider parameter.
-    # - EligibleAuthorization
+    # - model-name: EligibleAuthorization
 
   # The function invalid for memory cmdlet.
   # Custom cmdlet.

src/ManagedServices/ManagedServices.Autorest/custom/Get-AzManagedServicesMarketplaceDefinition.ps1

@@ -30,7 +30,7 @@ PS C:\> {{ Add code here }}
 .Inputs
 Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IManagedServicesIdentity
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.IMarketplaceRegistrationDefinition
+Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IMarketplaceRegistrationDefinition
 .Notes
 COMPLEX PARAMETER PROPERTIES
 
@@ -46,7 +46,7 @@ INPUTOBJECT <IManagedServicesIdentity>: Identity Parameter
 https://learn.microsoft.com/powershell/module/az.managedservices/get-azmanagedservicesmarketplacedefinition
 #>
 function Get-AzManagedServicesMarketplaceDefinition {
-    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.IMarketplaceRegistrationDefinition])]
+    [OutputType([Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IMarketplaceRegistrationDefinition])]
     [CmdletBinding(DefaultParameterSetName='ListWithScope', PositionalBinding=$false)]
     param(
         [Parameter(ParameterSetName='GetWithScope', Mandatory)]

src/ManagedServices/ManagedServices.Autorest/custom/New-AzManagedServicesAuthorizationObject.ps1

@@ -21,12 +21,13 @@ Create an in-memory object for Authorization.
 Create an in-memory object for Authorization.
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.Authorization
+Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization
 .Link
-https://learn.microsoft.com/powershell/module/Az.ManagedServices/new-AzManagedServicesAuthorizationObject
+https://learn.microsoft.com/powershell/module/Az.ManagedServices/new-azmanagedservicesauthorizationobject
 #>
 function New-AzManagedServicesAuthorizationObject {
-    [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.Authorization')]
+    [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.ModelCmdletAttribute()]
+    [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization')]
     [CmdletBinding(PositionalBinding=$false)]
     Param(
         [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Runtime.ParameterBreakingChangeAttribute("DelegatedRoleDefinitionId", "16.0.0", "9.0.0", "May 2026", OldParamaterType="Array", NewParameterType="List")]
@@ -45,7 +46,7 @@ function New-AzManagedServicesAuthorizationObject {
     )
 
     process {
-        $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.Authorization]::New()
+        $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization]::New()
 
         if ($PSBoundParameters.ContainsKey('DelegatedRoleDefinitionId')) {
             $Object.DelegatedRoleDefinitionId = $DelegatedRoleDefinitionId

src/ManagedServices/ManagedServices.Autorest/custom/New-AzManagedServicesEligibleAuthorizationObject.ps1

@@ -1,43 +1,45 @@
 
-    # ----------------------------------------------------------------------------------
-    #
-    # Copyright Microsoft Corporation
-    # Licensed under the Apache License, Version 2.0 (the \"License\");
-    # you may not use this file except in compliance with the License.
-    # You may obtain a copy of the License at
-    # http://www.apache.org/licenses/LICENSE-2.0
-    # Unless required by applicable law or agreed to in writing, software
-    # distributed under the License is distributed on an \"AS IS\" BASIS,
-    # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    # See the License for the specific language governing permissions and
-    # limitations under the License.
-    # ----------------------------------------------------------------------------------
+# ----------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# http://www.apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code
+# is regenerated.
+# ----------------------------------------------------------------------------------
 
-    <#
-    .Synopsis
-    Create a in-memory object for EligibleAuthorization
-    .Description
-    Create a in-memory object for EligibleAuthorization
+<#
+.Synopsis
+Create an in-memory object for EligibleAuthorization.
+.Description
+Create an in-memory object for EligibleAuthorization.
 
-    .Outputs
-    Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.EligibleAuthorization
-    .Link
-    https://learn.microsoft.com/powershell/module/az.ManagedServices/new-AzManagedServicesEligibleAuthorizationObject
-    #>
+.Outputs
+Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.EligibleAuthorization
+.Link
+https://learn.microsoft.com/powershell/module/az.ManagedServices/new-AzManagedServicesEligibleAuthorizationObject
+#>
     function New-AzManagedServicesEligibleAuthorizationObject {
-        [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.EligibleAuthorization')]
+        [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.ModelCmdletAttribute()]
+        [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.EligibleAuthorization')]
         [CmdletBinding(PositionalBinding=$false)]
         Param(
             [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Runtime.ParameterBreakingChangeAttribute("JustInTimeAccessPolicyManagedByTenantApprover", "16.0.0", "9.0.0", "May 2026", OldParamaterType="Array", NewParameterType="List")]
             [Parameter(HelpMessage="The list of managedByTenant approvers for the eligible authorization.")]
-            [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.IEligibleApprover[]]
+            [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IEligibleApprover[]]
             $JustInTimeAccessPolicyManagedByTenantApprover,
             [Parameter(HelpMessage="The maximum access duration in ISO 8601 format for just-in-time access requests.")]
             [System.TimeSpan]
             $JustInTimeAccessPolicyMaximumActivationDuration,
             [Parameter(HelpMessage="The multi-factor authorization provider to be used for just-in-time access requests.")]
-            [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Support.MultiFactorAuthProvider]
-            [ArgumentCompleter([Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Support.MultiFactorAuthProvider])]
+            [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.PSArgumentCompleterAttribute("Azure", "None")]
+            [string]
             $JustInTimeAccessPolicyMultiFactorAuthProvider,
             [Parameter(Mandatory, HelpMessage="The identifier of the Azure Active Directory principal.")]
             [string]
@@ -51,7 +53,7 @@
         )
 
         process {
-            $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.EligibleAuthorization]::New()
+            $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.EligibleAuthorization]::New()
 
             $Object.JustInTimeAccessPolicyManagedByTenantApprover = $JustInTimeAccessPolicyManagedByTenantApprover
 

src/ManagedServices/ManagedServices.Autorest/custom/autogen-model-cmdlets/New-AzManagedServicesAuthorizationObject.ps1

@@ -0,0 +1,66 @@
+
+# ----------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# http://www.apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code
+# is regenerated.
+# ----------------------------------------------------------------------------------
+
+<#
+.Synopsis
+Create an in-memory object for Authorization.
+.Description
+Create an in-memory object for Authorization.
+
+.Outputs
+Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization
+.Link
+https://learn.microsoft.com/powershell/module/Az.ManagedServices/new-azmanagedservicesauthorizationobject
+#>
+function New-AzManagedServicesAuthorizationObject {
+    [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.ModelCmdletAttribute()]
+    [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization')]
+    [CmdletBinding(PositionalBinding=$false)]
+    Param(
+
+        [Parameter(HelpMessage="The delegatedRoleDefinitionIds field is required when the roleDefinitionId refers to the User Access Administrator Role. It is the list of role definition ids which define all the permissions that the user in the authorization can assign to other principals.")]
+        [string[]]
+        $DelegatedRoleDefinitionId,
+        [Parameter(Mandatory, HelpMessage="The identifier of the Azure Active Directory principal.")]
+        [string]
+        $PrincipalId,
+        [Parameter(HelpMessage="The display name of the Azure Active Directory principal.")]
+        [string]
+        $PrincipalIdDisplayName,
+        [Parameter(Mandatory, HelpMessage="The identifier of the Azure built-in role that defines the permissions that the Azure Active Directory principal will have on the projected scope.")]
+        [string]
+        $RoleDefinitionId
+    )
+
+    process {
+        $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Authorization]::New()
+
+        if ($PSBoundParameters.ContainsKey('DelegatedRoleDefinitionId')) {
+            $Object.DelegatedRoleDefinitionId = $DelegatedRoleDefinitionId
+        }
+        if ($PSBoundParameters.ContainsKey('PrincipalId')) {
+            $Object.PrincipalId = $PrincipalId
+        }
+        if ($PSBoundParameters.ContainsKey('PrincipalIdDisplayName')) {
+            $Object.PrincipalIdDisplayName = $PrincipalIdDisplayName
+        }
+        if ($PSBoundParameters.ContainsKey('RoleDefinitionId')) {
+            $Object.RoleDefinitionId = $RoleDefinitionId
+        }
+        return $Object
+    }
+}
+

src/ManagedServices/ManagedServices.Autorest/custom/autogen-model-cmdlets/New-AzManagedServicesEligibleApproverObject.ps1

@@ -21,12 +21,13 @@ Create an in-memory object for EligibleApprover.
 Create an in-memory object for EligibleApprover.
 
 .Outputs
-Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.EligibleApprover
+Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.EligibleApprover
 .Link
-https://learn.microsoft.com/powershell/module/Az.ManagedServices/new-AzManagedServicesEligibleApproverObject
+https://learn.microsoft.com/powershell/module/Az.ManagedServices/new-azmanagedserviceseligibleapproverobject
 #>
 function New-AzManagedServicesEligibleApproverObject {
-    [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.EligibleApprover')]
+    [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.ModelCmdletAttribute()]
+    [OutputType('Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.EligibleApprover')]
     [CmdletBinding(PositionalBinding=$false)]
     Param(
 
@@ -39,7 +40,7 @@ function New-AzManagedServicesEligibleApproverObject {
     )
 
     process {
-        $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.EligibleApprover]::New()
+        $Object = [Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.EligibleApprover]::New()
 
         if ($PSBoundParameters.ContainsKey('PrincipalId')) {
             $Object.PrincipalId = $PrincipalId

src/ManagedServices/ManagedServices.Autorest/docs/Az.ManagedServices.md

@@ -21,23 +21,26 @@ Gets the registration definition details.
 Get the marketplace registration definition for the marketplace identifier.
 
 ### [New-AzManagedServicesAssignment](New-AzManagedServicesAssignment.md)
-Creates or updates a registration assignment.
+Create a registration assignment.
 
 ### [New-AzManagedServicesAuthorizationObject](New-AzManagedServicesAuthorizationObject.md)
 Create an in-memory object for Authorization.
 
 ### [New-AzManagedServicesDefinition](New-AzManagedServicesDefinition.md)
-Creates or updates a registration definition.
+Create a registration definition.
 
 ### [New-AzManagedServicesEligibleApproverObject](New-AzManagedServicesEligibleApproverObject.md)
 Create an in-memory object for EligibleApprover.
 
 ### [New-AzManagedServicesEligibleAuthorizationObject](New-AzManagedServicesEligibleAuthorizationObject.md)
-Create a in-memory object for EligibleAuthorization
+Create an in-memory object for EligibleAuthorization.
 
 ### [Remove-AzManagedServicesAssignment](Remove-AzManagedServicesAssignment.md)
 Deletes the specified registration assignment.
 
 ### [Remove-AzManagedServicesDefinition](Remove-AzManagedServicesDefinition.md)
 Deletes the registration definition.
 
+### [Update-AzManagedServicesDefinition](Update-AzManagedServicesDefinition.md)
+Update a registration definition.
+

src/ManagedServices/ManagedServices.Autorest/docs/Get-AzManagedServicesAssignment.md

@@ -127,7 +127,6 @@ Accept wildcard characters: False
 
 ### -InputObject
 Identity Parameter
-To construct, see NOTES section for INPUTOBJECT properties and create a hash table.
 
 ```yaml
 Type: Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IManagedServicesIdentity
@@ -180,7 +179,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## OUTPUTS
 
-### Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.IRegistrationAssignment
+### Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IRegistrationAssignment
 
 ## NOTES
 

src/ManagedServices/ManagedServices.Autorest/docs/Get-AzManagedServicesDefinition.md

@@ -107,7 +107,6 @@ Accept wildcard characters: False
 
 ### -InputObject
 Identity Parameter
-To construct, see NOTES section for INPUTOBJECT properties and create a hash table.
 
 ```yaml
 Type: Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IManagedServicesIdentity
@@ -160,7 +159,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## OUTPUTS
 
-### Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.IRegistrationDefinition
+### Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IRegistrationDefinition
 
 ## NOTES
 

src/ManagedServices/ManagedServices.Autorest/docs/Get-AzManagedServicesMarketplaceDefinition.md

@@ -165,7 +165,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
 
 ## OUTPUTS
 
-### Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.Api20200201Preview.IMarketplaceRegistrationDefinition
+### Microsoft.Azure.PowerShell.Cmdlets.ManagedServices.Models.IMarketplaceRegistrationDefinition
 
 ## NOTES