-
Notifications
You must be signed in to change notification settings - Fork 4.1k
upgrade websites module to autorest v4 #28268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3edff75
1111001
abfe591
345bc0f
0205cbd
925fde5
b69cbde
862287a
23df5e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,13 +37,6 @@ input-file: | |
| title: Websites | ||
| module-version: 0.1.0 | ||
| subject-prefix: $(service-name) | ||
| identity-correction-for-post: true | ||
| resourcegroup-append: true | ||
| nested-object-to-string: true | ||
|
|
||
| # For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option | ||
| use-extension: | ||
| "@autorest/powershell": "3.x" | ||
|
|
||
| directive: | ||
| #Modify operationId | ||
|
|
@@ -206,58 +199,20 @@ directive: | |
| verb: Unregister | ||
| subject: BuildUserProvidedFunctionApp | ||
|
|
||
| # Remove variant | ||
| # Remove variant | ||
| # Following is two common directive which are normally required in all the RPs | ||
| # 1. Remove the unexpanded parameter set | ||
| # 2. For New-* cmdlets, ViaIdentity is not required, so CreateViaIdentityExpanded is removed as well | ||
| - where: | ||
| variant: ^CreateViaIdentityExpanded$|^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: CustomDomain | ||
|
|
||
| remove: true | ||
| - where: | ||
| verb: Test | ||
| variant: ^Validate$|^ValidateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: CustomDomain | ||
| remove: true | ||
|
|
||
| - where: | ||
| variant: ^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: BuildAppSetting | ||
| remove: true | ||
|
|
||
| - where: | ||
| variant: ^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: FunctionAppSetting | ||
| remove: true | ||
|
|
||
| - where: | ||
| variant: ^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: Setting | ||
| subject: CustomDomain|BuildAppSetting|FunctionAppSetting|Setting|BuildFunctionAppSetting|UserRoleInvitationLink | ||
| variant: ^Create(?!.*?(Expanded|JsonFilePath|JsonString)) | ||
| remove: true | ||
|
|
||
| - where: | ||
| variant: ^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$ | ||
| variant: ^CreateViaIdentityExpanded$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: BuildFunctionAppSetting | ||
| remove: true | ||
|
|
||
| - where: | ||
| variant: ^Create$|^CreateViaIdentity$|^Update$|^UpdateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: UserRoleInvitationLink | ||
| subject: CustomDomain | ||
| remove: true | ||
|
Comment on lines
211
to
216
|
||
|
|
||
| - where: | ||
|
|
@@ -272,6 +227,14 @@ directive: | |
| variant: ^Update$|^UpdateViaIdentity$ | ||
| remove: true | ||
|
|
||
| - where: | ||
| verb: Test | ||
| variant: ^Validate$|^ValidateViaIdentity$ | ||
| # We got to keep the Create variant of CustomDomain because it's special that it doesn't have a | ||
| # CreateExpanded variant, because the only parameters are all in URL rather than request body | ||
| subject: CustomDomain | ||
| remove: true | ||
|
|
||
| - where: | ||
| verb: Reset | ||
| subject: ApiKey | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says that for
New-*cmdlets theCreateViaIdentityExpandedvariant is removed, but the directives only removeCreateViaIdentityExpandedforCustomDomainand the generated help still includesCreateViaIdentityExpandedfor otherNew-AzStaticWebApp*cmdlets (e.g., settings). Please align the comment with the actual directive behavior (or expand the directive if the intent is to remove these variants across the listed subjects).