Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Data Factory PowerShell module to add support for additional HDInsightOnDemand connection properties by updating the AutoRest generation to use a newer commit of the Azure REST API specifications.
Key Changes
- Updated AutoRest generation to use a newer API specification commit
- Added changelog entry for HDInsightOnDemand connection properties support
Reviewed Changes
Copilot reviewed 2 out of 27 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/DataFactory/DataFactory/ChangeLog.md | Added changelog entry documenting new HDInsightOnDemand connection properties support |
| src/DataFactory/DataFactory.Management.Sdk/README.md | Updated AutoRest commit hash and specification path to generate SDK from newer API specs |
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Added more support for HDInsightOnDemand connection properties. |
There was a problem hiding this comment.
The changelog entry lacks user-focused context and GitHub issue reference. It should explain what specific connection properties were added and how this impacts users. Additionally, include a reference to the related GitHub issue using the format [#12345]. Example: 'Added support for additional connection properties in HDInsightOnDemand linked services, including X, Y, and Z properties [#12345]'.
| commit: aabf307e72445d56c94f896bf2e9bd226fbdf3d6 | ||
| require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/readme.md | ||
| commit: c6e5248223e3bac9293ea4e0ac7c56f16c334e6a | ||
| require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/Microsoft.DataFactory/DataFactory/readme.md |
There was a problem hiding this comment.
The specification path has changed from 'specification/datafactory/resource-manager/readme.md' to 'specification/datafactory/resource-manager/Microsoft.DataFactory/DataFactory/readme.md'. This appears to be an intentional path update, but verify that this new path exists in commit c6e5248223e3bac9293ea4e0ac7c56f16c334e6a to prevent AutoRest generation failures.
| require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/Microsoft.DataFactory/DataFactory/readme.md | |
| require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/readme.md |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.