Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates test recordings for the SQL module, specifically sanitizing sensitive credentials in the TestExportDatabase test recording file. The change redacts a storage access key that was previously exposed in the test recording.
Key Changes:
- Redacted the
storageKeyvalue from an exposed Azure Storage access key to<REDACTED>in the export database request body - Minor JSON formatting update (closing brace placement)
| "EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvNDEyYjc4MmQtMjUxMS00YzZkLTk4ZjItM2VhMDFiMWM4M2MzL3Jlc291cmNlR3JvdXBzL3NxbC1pZS1jbWRsZXQtdGVzdC1yZzkwMDcwL3Byb3ZpZGVycy9NaWNyb3NvZnQuU3FsL3NlcnZlcnMvc3FsLWllLWNtZGxldC1zZXJ2ZXI5MDA3MC9kYXRhYmFzZXMvc3FsLWllLWNtZGxldC1kYjkwMDcwL2V4cG9ydD9hcGktdmVyc2lvbj0yMDIwLTAyLTAyLXByZXZpZXc=", | ||
| "RequestMethod": "POST", | ||
| "RequestBody": "{\r\n \"storageKeyType\": \"StorageAccessKey\",\r\n \"storageKey\": \"uMbXQiW536TvVLN8WyqGtX6xi+TfYlHeJBq+xtxv7Cij0mHgNh9R+4ATpNShO2oUaqF0vBIKNln16ZBJXQ224A==\",\r\n \"storageUri\": \"https://adealgpv2.blob.core.windows.net/container/testdb_ni5.bacpac/sql-ie-cmdlet-db90070.bacpac\",\r\n \"administratorLogin\": \"testuser\",\r\n \"administratorLoginPassword\": \"IEp@ssw0rd2577\",\r\n \"authenticationType\": \"sql\"\r\n}", | ||
| "RequestBody": "{\r\n \"storageKeyType\": \"StorageAccessKey\",\r\n \"storageKey\": \"<REDACTED>\",\r\n \"storageUri\": \"https://adealgpv2.blob.core.windows.net/container/testdb_ni5.bacpac/sql-ie-cmdlet-db90070.bacpac\",\r\n \"administratorLogin\": \"testuser\",\r\n \"administratorLoginPassword\": \"IEp@ssw0rd2577\",\r\n \"authenticationType\": \"sql\"\r\n}", |
There was a problem hiding this comment.
The administratorLoginPassword value "IEp@ssw0rd2577" is exposed in the test recording. While the storageKey has been properly redacted to "", the administrator password should also be sanitized in test recordings to prevent credential exposure. Consider redacting this sensitive value similar to how the storageKey was handled.
dolauli
approved these changes
Dec 19, 2025
RenSilvaAU
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update test recordings of Sql
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.