[DataFactory]Powershell Release#29024
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for enhanced connection properties for JiraV2 and NetezzaV2 in the Azure Data Factory PowerShell module. The changes include SDK model updates with new properties and a ChangeLog entry documenting the enhancement.
- Added new connection properties for Netezza linked services (server, port, uid, database, securityLevel)
- Added new dataset properties for Jira V2 (schema and table properties)
- Updated SDK commit reference to regenerate models from latest Azure REST API specifications
Reviewed changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DataFactory/DataFactory/ChangeLog.md | Adds release note for JiraV2 and NetezzaV2 connection properties support |
| src/DataFactory/DataFactory.Management.Sdk/README.md | Updates commit hash for SDK regeneration |
| src/DataFactory/DataFactory.Management.Sdk/Generated/Models/NetezzaSecurityLevelType.cs | Defines new security level constants for Netezza connections |
| src/DataFactory/DataFactory.Management.Sdk/Generated/Models/NetezzaLinkedServiceTypeProperties.cs | Adds new connection properties (server, port, uid, database, securityLevel) |
| src/DataFactory/DataFactory.Management.Sdk/Generated/Models/NetezzaLinkedService.cs | Adds new connection properties to the linked service model |
| src/DataFactory/DataFactory.Management.Sdk/Generated/Models/JiraTableDatasetTypeProperties.cs | Defines new dataset properties for Jira with V2 support |
| src/DataFactory/DataFactory.Management.Sdk/Generated/Models/JiraObjectDataset.cs | Adds schema and table properties for Jira V2 datasets |
| /// Gets or sets specifies the security level for the driver connection to the | ||
| /// data store. PreferredUnSecured : prefer unsecured, allow fallback to | ||
| /// secured connection if required. OnlyUnSecured : strictly unsecured, no | ||
| /// fallback. Possible values include: 'PreferredUnSecured', 'OnlyUnSecured' |
There was a problem hiding this comment.
Spelling error: "PreferredUnSecured" should be "PreferredUnsecured" and "OnlyUnSecured" should be "OnlyUnsecured". The word "unsecured" should not have a capital 'U' in the middle.
| /// PreferredUnSecured : prefer unsecured, allow fallback to secured connection | ||
| /// if required. OnlyUnSecured : strictly unsecured, no fallback. | ||
| /// Possible values include: 'PreferredUnSecured', 'OnlyUnSecured'</param> |
There was a problem hiding this comment.
Spelling error: "PreferredUnSecured" should be "PreferredUnsecured" and "OnlyUnSecured" should be "OnlyUnsecured". The word "unsecured" should not have a capital 'U' in the middle.
| /// PreferredUnSecured : prefer unsecured, allow fallback to secured connection | |
| /// if required. OnlyUnSecured : strictly unsecured, no fallback. | |
| /// Possible values include: 'PreferredUnSecured', 'OnlyUnSecured'</param> | |
| /// PreferredUnsecured : prefer unsecured, allow fallback to secured connection | |
| /// if required. OnlyUnsecured : strictly unsecured, no fallback. | |
| /// Possible values include: 'PreferredUnsecured', 'OnlyUnsecured'</param> |
| /// data store. PreferredUnSecured : prefer unsecured, allow fallback to | ||
| /// secured connection if required. OnlyUnSecured : strictly unsecured, no | ||
| /// fallback. Possible values include: 'PreferredUnSecured', 'OnlyUnSecured' |
There was a problem hiding this comment.
Spelling error: "PreferredUnSecured" should be "PreferredUnsecured" and "OnlyUnSecured" should be "OnlyUnsecured". The word "unsecured" should not have a capital 'U' in the middle.
| /// data store. PreferredUnSecured : prefer unsecured, allow fallback to | |
| /// secured connection if required. OnlyUnSecured : strictly unsecured, no | |
| /// fallback. Possible values include: 'PreferredUnSecured', 'OnlyUnSecured' | |
| /// data store. PreferredUnsecured : prefer unsecured, allow fallback to | |
| /// secured connection if required. OnlyUnsecured : strictly unsecured, no | |
| /// fallback. Possible values include: 'PreferredUnsecured', 'OnlyUnsecured' |
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Added more support for JiraV2 and NetezzaV2 connection properties. |
There was a problem hiding this comment.
The ChangeLog entry should explain the acronyms "JiraV2" and "NetezzaV2" on first use, as the primary audience is Azure PowerShell users who may not be familiar with these terms. Consider expanding to something like: "Added more support for Jira V2 (Jira Version 2) and Netezza V2 (Netezza Version 2) connection properties." Additionally, if this change relates to a GitHub issue, please reference it using the format [#12345].
| public const string PreferredUnSecured = "PreferredUnSecured"; | ||
| public const string OnlyUnSecured = "OnlyUnSecured"; |
There was a problem hiding this comment.
The constant names "PreferredUnSecured" and "OnlyUnSecured" use inconsistent capitalization. The prefix "Un" should be lowercase to follow proper camelCase conventions. Consider renaming to "PreferredUnsecured" and "OnlyUnsecured".
| public const string PreferredUnSecured = "PreferredUnSecured"; | |
| public const string OnlyUnSecured = "OnlyUnSecured"; | |
| public const string PreferredUnsecured = "PreferredUnSecured"; | |
| public const string OnlyUnsecured = "OnlyUnSecured"; |
| /// <param name="securityLevel">Specifies the security level for the driver connection to the data store. | ||
| /// PreferredUnSecured : prefer unsecured, allow fallback to secured connection | ||
| /// if required. OnlyUnSecured : strictly unsecured, no fallback. | ||
| /// Possible values include: 'PreferredUnSecured', 'OnlyUnSecured'</param> |
There was a problem hiding this comment.
Spelling error: "PreferredUnSecured" should be "PreferredUnsecured" (lowercase 'u' in 'unsecured'). The word "unsecured" should not have a capital 'U' in the middle.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.