Detection of Cloud Deployment Flow using registry key

[Samhitha-Microsoft]

Description

Previously, when the cloud deployment is done, the nodes would be ARC enabled prior. But, when repair registration is triggered, The ARc enablement is being triggered again which should not be happening. This was happening because the env variable that was used to determine the cloud deployment flow would be expired after the first scenario.

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[Copilot]

Pull request overview

This pull request improves the detection mechanism for cloud deployment scenarios in Azure Stack HCI registration. Previously, the detection relied solely on an environment variable that expired after initial deployment, causing ARC enablement to be incorrectly triggered again during repair registration. The fix adds a persistent registry key check as a fallback detection method.

Changes:

• Added registry-based detection for cloud deployment scenarios to supplement the existing environment variable check
• Updated the ChangeLog to document the enhancement

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/StackHCI/StackHCI/ChangeLog.md	Documents the new cloud deployment detection mechanism using registry key
src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1	Enhances ValidateCloudDeployment function with registry key fallback check and improved logging

[isra-fel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[vidai-msft]

@Samhitha-Microsoft Az 15.2.0 has already been finalized. The PR will be merged and released in the next version.

[vidai-msft]

Please address the review comment.

[Samhitha-Microsoft]

@Samhitha-Microsoft Az 15.2.0 has already been finalized. The PR will be merged and released in the next version.

Okay, we can take it in the next release.

[Samhitha-Microsoft]

Please address the review comment.

Updated the message.

[vidai-msft]

LGTM

[vidai-msft]

/azp run azure-powershell - security-tools

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[isra-fel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[vidai-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).