Skip to content

Do not arc enable the nodes for cloud deployed clusters even if they are disconnected from ARC#29074

Merged
vidai-msft merged 3 commits intoAzure:mainfrom
Samhitha-Microsoft:user/samhitham/DoNotArcENableNodesOnCloudDeployment
Jan 20, 2026
Merged

Do not arc enable the nodes for cloud deployed clusters even if they are disconnected from ARC#29074
vidai-msft merged 3 commits intoAzure:mainfrom
Samhitha-Microsoft:user/samhitham/DoNotArcENableNodesOnCloudDeployment

Conversation

@Samhitha-Microsoft
Copy link
Copy Markdown
Contributor

Description

In the current registration flow, if the nodes are disconnected from Arc, during repair registration, the nodes will be arc enabled again. But, in case of cloud deployment Arc enablement should not be done even if the machine is disconnected form Arc.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings January 19, 2026 11:25
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the Azure Stack HCI registration flow to prevent automatic Arc enablement of cluster nodes during repair registration when the cluster was deployed through cloud deployment. The change ensures that for cloud-deployed clusters, Arc enablement is handled by the cloud deployment process rather than being triggered manually during repair operations.

Changes:

  • Updated MSI flow logic to detect cloud deployments and skip manual Arc enablement in such cases
  • Added appropriate logging for the new cloud deployment skip path
  • Updated ChangeLog to document the behavior change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/StackHCI/StackHCI/ChangeLog.md Documents the new behavior where Arc enablement is skipped for cloud-deployed clusters during repair registration
src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 Adds cloud deployment detection in Invoke-MSIFlow to conditionally skip Arc enablement, wrapping the existing enablement logic in an else block for non-cloud deployments

@isra-fel
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@vidai-msft
Copy link
Copy Markdown
Contributor

@Samhitha-Microsoft Please resolve the conflict.

Copilot AI review requested due to automatic review settings January 20, 2026 10:45
@Samhitha-Microsoft
Copy link
Copy Markdown
Contributor Author

@Samhitha-Microsoft Please resolve the conflict.

Done.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@isra-fel
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft merged commit dce6fd4 into Azure:main Jan 20, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants