-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update ChangeLog for DataProtection #29106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changelog entry lacks sufficient detail for Azure PowerShell users. According to the ChangeLog guidelines:
Missing GitHub issue reference: The entry should reference related GitHub issues when applicable (e.g., "[[Do not Squash][Storage] Merge latest change from master to storage preview branch #12345]")
Insufficient user context: The entry should explain what the feature means for users and how it impacts their usage, not just state that it was added.
Missing implementation details: Similar entries in this file include sub-bullets with additional context, such as which cmdlets were added or modified. For example, this vault soft delete feature appears to involve cmdlets like 'Undo-AzDataProtectionVaultDeletion' and 'Search-AzDataProtectionSoftDeletedVaultBackupInstanceInAzGraph'.
Consider revising to follow the pattern seen in Version 2.1.0 (line 54) which says "Added soft delete and MUA feature for Backup vaults" or Version 2.4.0 (line 45) which provides specific cmdlet names. The entry should include sub-bullets explaining what users can now do with this feature (e.g., undelete vaults, search for soft deleted instances).