[ComputeLimit] Fix oob failure by NoriZC · Pull Request #29288 · Azure/azure-powershell

NoriZC · 2026-03-20T09:33:59Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-03-20T09:34:02Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull request overview

This PR updates the Az.ComputeLimit module’s packaging and documentation assets to address an out-of-box failure scenario, primarily by aligning help/solution/manifest artifacts with the generated AutoRest output.

Changes:

Updated cmdlet markdown help files (parameter sets/signatures and external help file metadata).
Updated module packaging artifacts (module manifest exports and solution project reference to generated csproj).
Adjusted test environment loading script and added module docs/resources metadata files.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/ComputeLimit/ComputeLimit/help/Add-AzGuestSubscription.md	Refreshes help metadata and parameter set sections for Add-AzGuestSubscription.
src/ComputeLimit/ComputeLimit/help/Add-AzSharedLimit.md	Refreshes help metadata and parameter set sections for Add-AzSharedLimit.
src/ComputeLimit/ComputeLimit/help/Get-AzGuestSubscription.md	Refreshes help metadata and parameter set sections for Get-AzGuestSubscription.
src/ComputeLimit/ComputeLimit/help/Get-AzSharedLimit.md	Refreshes help metadata and parameter set sections for Get-AzSharedLimit.
src/ComputeLimit/ComputeLimit/help/Remove-AzGuestSubscription.md	Refreshes help metadata and parameter set sections for Remove-AzGuestSubscription.
src/ComputeLimit/ComputeLimit/help/Remove-AzSharedLimit.md	Refreshes help metadata and parameter set sections for Remove-AzSharedLimit.
src/ComputeLimit/ComputeLimit/ChangeLog.md	Touches release notes structure around Upcoming Release / initial version section.
src/ComputeLimit/ComputeLimit/Az.ComputeLimit.psd1	Adjusts manifest export settings (aliases/variables) and updates generated timestamp.
src/ComputeLimit/ComputeLimit.sln	Repoints Az.ComputeLimit project to the generated ComputeLimit.Autorest csproj and updates project GUID mappings.
src/ComputeLimit/ComputeLimit.Autorest/test/loadEnv.ps1	Updates how env json is read for tests.
src/ComputeLimit/ComputeLimit.Autorest/resources/README.md	Adds repository-only resources folder README for the module.
src/ComputeLimit/ComputeLimit.Autorest/generate-info.json	Updates generation tracking id.
src/ComputeLimit/ComputeLimit.Autorest/docs/Az.ComputeLimit.md	Adds module landing page for generated help docs.

Copilot · 2026-03-20T09:39:03Z

src/ComputeLimit/ComputeLimit.Autorest/resources/README.md

@@ -0,0 +1,11 @@
+# Resources
+This directory can contain any additional resources for module that are not required at runtime. This directory **does not** get packaged with the module. If you have assets for custom implementation, place them into the `..\custom` folder.


This README uses a Windows-style relative path (..\custom). Other module template READMEs in this repo use forward-slash relative paths (../custom) for consistency and to avoid confusion on non-Windows platforms; update the path accordingly.

Suggested change

This directory can contain any additional resources for module that are not required at runtime. This directory **does not** get packaged with the module. If you have assets for custom implementation, place them into the `..\custom` folder.

This directory can contain any additional resources for module that are not required at runtime. This directory **does not** get packaged with the module. If you have assets for custom implementation, place them into the `../custom` folder.

Copilot · 2026-03-20T09:39:04Z

src/ComputeLimit/ComputeLimit/ChangeLog.md

@@ -18,4 +18,6 @@
        - Additional information about change #1
 -->
 ## Upcoming Release


## Upcoming Release is empty, but this PR changes module packaging/build artifacts (manifest/solution/help). Either add a brief user-facing entry under ## Upcoming Release describing the fix (and reference the related issue if applicable), or revert the changelog edit if no release note is intended.

Suggested change

## Upcoming Release

## Upcoming Release

* Updated packaging configuration for Az.ComputeLimit module

- No changes to cmdlet behavior, improved build and manifest setup

Copilot · 2026-03-20T09:39:04Z

src/ComputeLimit/ComputeLimit/ChangeLog.md

 -->
 ## Upcoming Release
+
+## Version 0.1.0


The changelog template at the top specifies release sections should be titled ## YYYY.MM.DD - Version X.Y.Z. ## Version 0.1.0 doesn’t follow that format; please include the release date in the header to match the documented convention.

Suggested change

## Version 0.1.0

## 2024.01.01 - Version 0.1.0

Copilot · 2026-03-20T09:39:04Z

src/ComputeLimit/ComputeLimit.Autorest/test/loadEnv.ps1

 $env = @{}
 if (Test-Path -Path $envFilePath) {
-    $env = Get-Content $envFilePath | ConvertFrom-Json
+    $env = Get-Content (Join-Path $PSScriptRoot $envFile) | ConvertFrom-Json


$envFilePath is computed above (including the fallback to the parent directory), but the file is read using (Join-Path $PSScriptRoot $envFile) instead. This ignores the fallback logic and will fail when the env json only exists at $envFilePath. Use $envFilePath for Get-Content (and keep path resolution in one place).

Suggested change

$env = Get-Content (Join-Path $PSScriptRoot $envFile) | ConvertFrom-Json

$env = Get-Content -Path $envFilePath | ConvertFrom-Json

Copilot · 2026-03-20T09:39:04Z

src/ComputeLimit/ComputeLimit.Autorest/test/loadEnv.ps1

 } else {
    $envFilePath = Join-Path $PSScriptRoot '..\$envFile'
 }


The fallback path uses Join-Path $PSScriptRoot '..\$envFile' inside single quotes, so $envFile is not expanded and the literal string ..\$envFile is used. Build the fallback path without single-quoting the variable portion (e.g., join .. and $envFile as separate path segments).

Copilot · 2026-03-20T09:39:05Z

src/ComputeLimit/ComputeLimit.sln

@@ -1,4 +1,4 @@
-
+


The solution file now has a blank first line before Microsoft Visual Studio Solution File, Format Version 12.00. Some tooling expects the header on the first line; remove the leading empty line (if the intent was to drop a UTF-8 BOM, ensure the header remains the first line).

Suggested change

fix oob failure

bd66285

Copilot AI review requested due to automatic review settings March 20, 2026 09:34

Copilot started reviewing on behalf of NoriZC March 20, 2026 09:36 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

revert generate info

643962a

VeryEarly approved these changes Mar 20, 2026

View reviewed changes

VeryEarly enabled auto-merge (squash) March 20, 2026 09:45

VeryEarly merged commit 8ff34ae into main Mar 20, 2026
12 checks passed

VeryEarly deleted the nori/fix-computelimit branch March 20, 2026 10:21

notyashhh pushed a commit that referenced this pull request Mar 24, 2026

[ComputeLimit] Fix oob failure (#29288)

999d4e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ComputeLimit] Fix oob failure#29288

[ComputeLimit] Fix oob failure#29288
VeryEarly merged 2 commits intomainfrom
nori/fix-computelimit

NoriZC commented Mar 20, 2026

Uh oh!

azure-client-tools-bot-prd bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,11 @@
		# Resources
		This directory can contain any additional resources for module that are not required at runtime. This directory does not get packaged with the module. If you have assets for custom implementation, place them into the `..\custom` folder.

	$env = Get-Content (Join-Path $PSScriptRoot $envFile) \| ConvertFrom-Json
	$env = Get-Content -Path $envFilePath \| ConvertFrom-Json

Conversation

NoriZC commented Mar 20, 2026

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants