Merged
Conversation
- Add BeforeAll blocks to create test resources before tests run - Add AfterAll blocks to clean up resources after tests complete - Update recording files with successful test runs - Fixes 7 previously failing tests (ResourceNotFound errors)
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FileShare AutoRest test suites to be more self-sufficient by ensuring a target file share exists before running Get-* / snapshot tests, and by cleaning up created resources afterward.
Changes:
- Added
BeforeAllsetup inGet-AzFileShare.Tests.ps1to createfileShareName01when missing, andAfterAllteardown to remove it. - Added
BeforeAllsetup inGet-AzFileShareSnapshot.Tests.ps1to ensure the parent share exists, plusAfterAllteardown to delete snapshots and the share. - Updated
Get-AzFileShare.Recording.jsonto include the additional setup/teardown HTTP interactions.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/FileShare/FileShare.Autorest/test/Get-AzFileShareSnapshot.Tests.ps1 | Adds suite-level setup/teardown around snapshot tests (ensure share exists; cleanup snapshots/share). |
| src/FileShare/FileShare.Autorest/test/Get-AzFileShare.Tests.ps1 | Adds suite-level setup/teardown around Get tests (ensure share exists; cleanup share). |
| src/FileShare/FileShare.Autorest/test/Get-AzFileShare.Recording.json | Updates recordings to reflect the new setup/teardown calls for playback mode. |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
blueww
approved these changes
Mar 24, 2026
notyashhh
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.