[AutoPR sdk-resourcemanager/dnsresolver/armdnsresolver]-generated-from-SDK Generation - Go-5425116#25371
Merged
jamesvoongms merged 3 commits intoAzure:mainfrom Oct 28, 2025
Conversation
….Network/DnsResolver/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '3ec630fc62ebc03e9adf238cb2fb0b538d93ead4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5425116 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
jamesvoongms
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DNS Resolver SDK from API version 2025-05-01 to 2025-10-01-preview, transitioning from AutoRest to Go Code Generator. The changes include module path updates (v2), API version updates, header name standardization to lowercase, and code generation pattern improvements.
Key Changes
- Updated module path from
armdnsresolvertoarmdnsresolver/v2 - Migrated API version from
2025-05-01to2025-10-01-preview - Standardized HTTP header names to lowercase (e.g.,
If-Match→if-match) - Reorganized example test code structure and improved response handling
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updated module path to v2 and Go version to 1.24.0 |
version.go |
Added version constants for module tracking |
tsp-location.yaml |
New TypeSpec configuration file |
virtualnetworklinks_client.go |
Updated API version and header names to lowercase |
virtualnetworklinks_client_example_test.go |
Restructured examples with improved response handling |
responses.go |
Updated response type documentation comments |
models.go |
Renamed DomainListResult to DomainListListResult and updated field documentation |
models_serde.go |
Added serialization support for new model fields |
policyvirtualnetworklinks_client*.go |
Applied consistent API version and header updates |
policies_client*.go |
Applied consistent API version and header updates |
outboundendpoints_client*.go |
Applied consistent API version and header updates |
inboundendpoints_client*.go |
Applied consistent API version and header updates |
forwardingrules_client*.go |
Applied consistent API version and header updates |
domainlists_client.go |
Updated to use DomainListListResult |
fake/*.go |
Updated all fake server implementations with header name changes and improved regex validation |
time_rfc3339.go |
Updated code generator comment |
options.go |
Updated code generator comment |
testdata/_metadata.json |
Added metadata for new API version |
Member
|
@jamesvoongms It seems there are some spelling issues for the example files: https://github.com/Azure/azure-rest-api-specs/pull/37724/files#diff-87ef7a711badd69b46d1acc7a457511de2870aa783922f4a41dae26231e9a715, would you fix them? |
Member
|
@jliusan please help fix the ci failure, thanks! |
Member
fixed |
Member
|
@JiaqiZhang-Dev , do the grammar fixes need to be done before this merge? |
Member
The spelling issue are all came from example files, there is no impact for SDK customers. |
JiaqiZhang-Dev
approved these changes
Oct 28, 2025
Member
|
OK thank you, will fix in new iteration |
azure-sdk
deleted the
sdkauto/sdk-resourcemanager-dnsresolver/armdnsresolver-5425116
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/dnsresolver/resource-manager/Microsoft.Network/DnsResolver/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '3ec630fc62ebc03e9adf238cb2fb0b538d93ead4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5425116 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=61053214-6a8e-f011-b4cc-0022480bb79b Submitted by: jamesvoong@microsoft.com
Release Plan Details
Spec pull request: Add 2025-10-01-preview changes to dns resolver azure-rest-api-specs#37724
Spec API version: 2025-10-01-preview